Source/core/dom/Position.cpp - Issue 870013003: Div having contentEditable and display:grid cannot be edited if it is empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Position.cpp

Issue 870013003: Div having contentEditable and display:grid cannot be edited if it is empty. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add minimumLogicalHeightForEmptyLine Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/events/key-events-in-editable-gridbox.html ('K') | « LayoutTests/fast/events/key-events-in-editable-gridbox-expected.txt ('k') | Source/core/rendering/RenderBox.h » ('j') | Source/core/rendering/RenderBox.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/Position.cpp

diff --git a/Source/core/dom/Position.cpp b/Source/core/dom/Position.cpp

index 56f1304b5a7dc7a24e6e0a4b7802b953f4c41223..8e42b28271546bf19c40c2c08915ffee1e499a97 100644

--- a/Source/core/dom/Position.cpp

+++ b/Source/core/dom/Position.cpp

@@ -855,7 +855,7 @@ bool Position::isCandidate() const

if (isHTMLHtmlElement(*m_anchorNode))

return false;

- if (renderer->isRenderBlockFlow() || renderer->isFlexibleBox()) {

+ if (renderer->isRenderBlockFlow() || renderer->isFlexibleBox() || renderer->isRenderGrid()) {

if (toRenderBlock(renderer)->logicalHeight() || isHTMLBodyElement(*m_anchorNode)) {

if (!Position::hasRenderedNonAnonymousDescendantsWithHeight(renderer))

return atFirstEditingPositionForNode() && !Position::nodeIsUserSelectNone(deprecatedNode());