dart2js: add type lookup in the new emitter.

dart2js: add type lookup in the new emitter.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43189

[zarah, 2015-01-23 08:58:11]

zarah@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-01-23 10:46:31]

https://codereview.chromium.org/869953002/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/869953002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:430:
holdersMap[classes[i]] = holderIndex;
You can directly store the holder in the map.
That is: holdersMap[classes[i]] = holders[holderIndex]
Also makes the code above easier:

function(name) { return holdersMap[name][name]; }

https://codereview.chromium.org/869953002/diff/1/sdk/lib/_internal/compiler/j...
File sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart (right):

https://codereview.chromium.org/869953002/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart:53: const
GET_TYPE_FROM_NAME = 'getTypeFromName';
Add dartdoc what this function should do.

[zarah, 2015-01-23 12:22:19]

https://codereview.chromium.org/869953002/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/869953002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:430:
holdersMap[classes[i]] = holderIndex;
On 2015/01/23 10:46:31, floitsch wrote:
> You can directly store the holder in the map.
> That is: holdersMap[classes[i]] = holders[holderIndex]
> Also makes the code above easier:
> 
> function(name) { return holdersMap[name][name]; }

Done.

https://codereview.chromium.org/869953002/diff/1/sdk/lib/_internal/compiler/j...
File sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart (right):

https://codereview.chromium.org/869953002/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart:53: const
GET_TYPE_FROM_NAME = 'getTypeFromName';
On 2015/01/23 10:46:31, floitsch wrote:
> Add dartdoc what this function should do.

Done.

[floitsch, 2015-01-23 22:32:03]

https://codereview.chromium.org/869953002/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/869953002/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:140:
js.js.statement('var holdersMap = {}')
Object.create(null);

[floitsch, 2015-01-23 22:33:42]

https://codereview.chromium.org/869953002/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/869953002/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:20:
GET_TYPE_FROM_NAME;
They are sorted by name.

[floitsch, 2015-01-23 22:39:21]

Another one...

https://codereview.chromium.org/869953002/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/869953002/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:224: js.js(
"""function(name) {return holdersMap[name][name];}""");
must call ensureResolved!

[zarah, 2015-01-26 17:43:43]

Patchset #3 (id:40001) has been deleted

[zarah, 2015-01-26 17:54:11]

PTAL

https://codereview.chromium.org/869953002/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/869953002/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:20:
GET_TYPE_FROM_NAME;
On 2015/01/23 22:33:42, floitsch wrote:
> They are sorted by name.

Done.

https://codereview.chromium.org/869953002/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:140:
js.js.statement('var holdersMap = {}')
On 2015/01/23 22:32:03, floitsch wrote:
> Object.create(null);

Done.

https://codereview.chromium.org/869953002/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:224: js.js(
"""function(name) {return holdersMap[name][name];}""");
On 2015/01/23 22:39:21, floitsch wrote:
> must call ensureResolved!

Done.

[floitsch, 2015-01-27 12:26:50]

Still LGTM.

[zarah, 2015-01-27 12:41:05]

Thanks :-)

[zarah, 2015-01-27 16:21:08]

Committed patchset #5 (id:100001) manually as 43189 (presubmit successful).