Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 869753002: Update {virtual,override,final} to follow C++11 style in chrome, round 2. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, extensions-reviews_chromium.org, mlamouri+watch-notifications_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, peter+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in chrome, round 2. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Committed: https://crrev.com/8dafeb843c148804b63d5728fe3153d7b1b53a12 Cr-Commit-Position: refs/heads/master@{#312740}

Patch Set 1 #

Patch Set 2 : Fix format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/message_center_settings_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_browser_process_platform_part.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.h View 1 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/test/base/view_event_test_platform_part_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/webui/certificate_viewer_ui_test-inl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
5 years, 11 months ago (2015-01-22 22:28:23 UTC) #2
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-22 22:50:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869753002/20001
5 years, 11 months ago (2015-01-22 22:58:59 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-23 01:04:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869753002/20001
5 years, 11 months ago (2015-01-23 01:06:48 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 01:51:25 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 01:52:31 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8dafeb843c148804b63d5728fe3153d7b1b53a12
Cr-Commit-Position: refs/heads/master@{#312740}

Powered by Google App Engine
This is Rietveld 408576698