chrome/test/base/testing_profile.h - Issue 869753002: Update {virtual,override,final} to follow C++11 style in chrome, round 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/testing_profile.h

Issue 869753002: Update {virtual,override,final} to follow C++11 style in chrome, round 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix format Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/base/testing_browser_process_platform_part.h ('k') | chrome/test/base/view_event_test_platform_part_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/base/testing_profile.h

diff --git a/chrome/test/base/testing_profile.h b/chrome/test/base/testing_profile.h

index edb28debda7535d960bc880f40a6c27af1c53f8b..fc95195345f24edeb96e5134b5d4879a5dc14e6b 100644

--- a/chrome/test/base/testing_profile.h

+++ b/chrome/test/base/testing_profile.h

@@ -310,13 +310,9 @@ class TestingProfile : public Profile {

void SetExitType(ExitType exit_type) override {}

ExitType GetLastSessionExitType() override;

#if defined(OS_CHROMEOS)

- virtual void ChangeAppLocale(const std::string&,

- AppLocaleChangedVia) override {

- }

- virtual void OnLogin() override {

- }

- virtual void InitChromeOSPreferences() override {

- }

+ void ChangeAppLocale(const std::string&, AppLocaleChangedVia) override {}

+ void OnLogin() override {}

+ void InitChromeOSPreferences() override {}

#endif // defined(OS_CHROMEOS)

PrefProxyConfigTracker* GetProxyConfigTracker() override;