Fix install-build-deps-android.sh launching of get_sdk_extras_packages.py

Fix install-build-deps-android.sh launching of get_sdk_extras_packages.py

This is a two part fix:
1. Fix get_sdk_extras_packages.py to correctly identify its own location.
2. Fix install-build-deps-android.sh to launch get_sdk_extras_packages.py
   when the current-working-directory isn't the location of the script.
This fixes the script when run in the way recommended by
https://code.google.com/p/chromium/wiki/AndroidBuildInstructions

Committed: https://crrev.com/cc5297cfe2d5cbf1d61aa942308f5fb93adf3e89
Cr-Commit-Position: refs/heads/master@{#314140}

[pauljensen, 2015-01-30 15:52:24]

pauljensen@chromium.org changed reviewers:
+ thakis@chromium.org

[pauljensen, 2015-01-30 15:53:18]

Nico, PTAL.  I think this gets these scripts working...when run in the
recommended way.

[Nico, 2015-01-30 17:29:37]

This script used to work. The stuff your touching was recently modified by
navabi (reviewed by cjhopman), so cc'ing them. Your change makese sense to me,
one comment below though:

https://codereview.chromium.org/869633003/diff/1/build/get_sdk_extras_package...
File build/get_sdk_extras_packages.py (right):

https://codereview.chromium.org/869633003/diff/1/build/get_sdk_extras_package...
build/get_sdk_extras_packages.py:11: FILENAME =
inspect.getframeinfo(inspect.currentframe()).filename
The usual way we do this is 

THIS_DIR = os.path.abspath(os.path.dirname(__file__))

Does that not work here?

[pauljensen, 2015-01-30 17:31:41]

https://codereview.chromium.org/869633003/diff/1/build/get_sdk_extras_package...
File build/get_sdk_extras_packages.py (right):

https://codereview.chromium.org/869633003/diff/1/build/get_sdk_extras_package...
build/get_sdk_extras_packages.py:11: FILENAME =
inspect.getframeinfo(inspect.currentframe()).filename
On 2015/01/30 17:29:37, Nico wrote:
> The usual way we do this is 
> 
> THIS_DIR = os.path.abspath(os.path.dirname(__file__))
> 
> Does that not work here?

__file__ is not defined when this is invoked in ways like:
  python -c 'execfile(...)'
which is how install-build-deps-android.sh used to invoke it.

[Nico, 2015-01-30 17:33:18]

On 2015/01/30 17:31:41, pauljensen wrote:
>
https://codereview.chromium.org/869633003/diff/1/build/get_sdk_extras_package...
> File build/get_sdk_extras_packages.py (right):
> 
>
https://codereview.chromium.org/869633003/diff/1/build/get_sdk_extras_package...
> build/get_sdk_extras_packages.py:11: FILENAME =
> inspect.getframeinfo(inspect.currentframe()).filename
> On 2015/01/30 17:29:37, Nico wrote:
> > The usual way we do this is 
> > 
> > THIS_DIR = os.path.abspath(os.path.dirname(__file__))
> > 
> > Does that not work here?
> 
> __file__ is not defined when this is invoked in ways like:
>   python -c 'execfile(...)'
> which is how install-build-deps-android.sh used to invoke it.

It doesn't anymore though. Is there ever a good reason for doing that?

[pauljensen, 2015-01-30 17:34:03]

On 2015/01/30 17:33:18, Nico wrote:
> On 2015/01/30 17:31:41, pauljensen wrote:
> >
>
https://codereview.chromium.org/869633003/diff/1/build/get_sdk_extras_package...
> > File build/get_sdk_extras_packages.py (right):
> > 
> >
>
https://codereview.chromium.org/869633003/diff/1/build/get_sdk_extras_package...
> > build/get_sdk_extras_packages.py:11: FILENAME =
> > inspect.getframeinfo(inspect.currentframe()).filename
> > On 2015/01/30 17:29:37, Nico wrote:
> > > The usual way we do this is 
> > > 
> > > THIS_DIR = os.path.abspath(os.path.dirname(__file__))
> > > 
> > > Does that not work here?
> > 
> > __file__ is not defined when this is invoked in ways like:
> >   python -c 'execfile(...)'
> > which is how install-build-deps-android.sh used to invoke it.
> 
> It doesn't anymore though. Is there ever a good reason for doing that?

In case someone does.

[Nico, 2015-01-30 17:59:49]

On 2015/01/30 17:34:03, pauljensen wrote:
> On 2015/01/30 17:33:18, Nico wrote:
> > On 2015/01/30 17:31:41, pauljensen wrote:
> > >
> >
>
https://codereview.chromium.org/869633003/diff/1/build/get_sdk_extras_package...
> > > File build/get_sdk_extras_packages.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/869633003/diff/1/build/get_sdk_extras_package...
> > > build/get_sdk_extras_packages.py:11: FILENAME =
> > > inspect.getframeinfo(inspect.currentframe()).filename
> > > On 2015/01/30 17:29:37, Nico wrote:
> > > > The usual way we do this is 
> > > > 
> > > > THIS_DIR = os.path.abspath(os.path.dirname(__file__))
> > > > 
> > > > Does that not work here?
> > > 
> > > __file__ is not defined when this is invoked in ways like:
> > >   python -c 'execfile(...)'
> > > which is how install-build-deps-android.sh used to invoke it.
> > 
> > It doesn't anymore though. Is there ever a good reason for doing that?
> 
> In case someone does.

I think we should just say "don't do this, it's silly", unless it isn't silly
for some reason. According to cs.chromium.org, you updated the only use to be
non-silly.

[pauljensen, 2015-01-31 02:19:40]

On 2015/01/30 17:59:49, Nico wrote:
> I think we should just say "don't do this, it's silly", unless it isn't silly
> for some reason. According to http://cs.chromium.org, you updated the only use
to be
> non-silly.

Okay, done. PTAL.

[Nico, 2015-01-31 02:54:08]

lgtm

[pauljensen, 2015-02-02 13:00:56]

The CQ bit was checked by pauljensen@chromium.org

[commit-bot: I haz the power, 2015-02-02 13:01:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/869633003/20001

[commit-bot: I haz the power, 2015-02-02 13:54:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-02 13:54:59]

Patchset 2 (id:??) landed as
https://crrev.com/cc5297cfe2d5cbf1d61aa942308f5fb93adf3e89
Cr-Commit-Position: refs/heads/master@{#314140}