build/install-build-deps-android.sh - Issue 869633003: Fix install-build-deps-android.sh launching of get_sdk_extras_packages.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/install-build-deps-android.sh

Issue 869633003: Fix install-build-deps-android.sh launching of get_sdk_extras_packages.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: switch from inspect to __file__ Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/install-build-deps-android.sh

diff --git a/build/install-build-deps-android.sh b/build/install-build-deps-android.sh

index 4233c7f38f12a41ee47a1331f8bd20641aa63da1..5d95ed5413db1fd5924f82c76860faa7480b306a 100755

--- a/build/install-build-deps-android.sh

+++ b/build/install-build-deps-android.sh

@@ -94,10 +94,10 @@ fi

if test "$skip_inst_sdk_packages" != 1; then

echo 'checking for sdk packages install'

- # Get the SDK extras packages to install from the DEPS file 'sdkextras' hook.

- packages="$(python -c 'execfile("./get_sdk_extras_packages.py")')"

# Use absolute path to call 'android' so script can be run from any directory.

cwd=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )

+ # Get the SDK extras packages to install from the DEPS file 'sdkextras' hook.

+ packages="$(python ${cwd}/get_sdk_extras_packages.py)"

for package in "${packages}"; do

pkg_id=$(${cwd}/../third_party/android_tools/sdk/tools/android list sdk | \

grep -i "$package," | \

« no previous file with comments | « build/get_sdk_extras_packages.py ('k') | no next file » | no next file with comments »