Define class names for views class in c/b/ui/views

chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h
index 0ac06c0eb4240b4bb58e53a470bed3ae4cc91607..cfbace4ccbd0ebfaba81b32d46333d4cc0d196b4 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h
@@ -31,6 +31,7 @@ class BookmarkBarInstructionsView : public views::View,
       BookmarkBarInstructionsDelegate* delegate);
 
   // views::View overrides.
+  const char* GetClassName() const override;

[Peter Kasting, 2015/01/23 07:28:10]

In theory, these are listed in the same order that they're listed in the base
class declaration.

In practice we probably already don't get this right in a lot of places, but it
would be nice not to introduce new instances thereof.

Also (and this will probably make your life easier in this regard), all the
GetClassName() overrides you're adding should be private, since no one needs to
call them via a derived class pointer.  Again, we should have been doing this
for all such overrides, but we're already sloppy about it and you don't need to
fix existing cases.

(These comments apply throughout the CL)

[oshima, 2015/01/24 01:23:07]

Done. Made others private too as they're not called via a derived class pointer.

   gfx::Size GetPreferredSize() const override;
   void Layout() override;
   void OnThemeChanged() override;