DescriptionRevert of Don't refcount tracking id -> slot id mapping. (patchset #6 id:120001 of https://codereview.chromium.org/785753002/)
Reason for revert:
Reverting due to memory failures.
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%283%29/builds/5041/steps/memory%20test%3A%20content/logs/stdio
{
UNINITIALIZED READ
name=<insert_a_suppression_name_here>
content.dll!content::TouchEventQueue::TouchMoveSlopSuppressor::FilterEvent
content.dll!content::TouchEventQueue::FilterBeforeForwarding
content.dll!content::TouchEventQueue::TryForwardNextEventToRenderer
content.dll!content::TouchEventQueue::ProcessTouchAck
content.dll!content::InputRouterImpl::ProcessInputEventAck
content.dll!content::InputRouterImpl::OnInputEventAck
content.dll!InputHostMsg_HandleInputEvent_ACK::Dispatch<>
content.dll!content::InputRouterImpl::OnMessageReceived
content.dll!content::RenderWidgetHostImpl::OnMessageReceived
*!content::RenderWidgetHostViewAuraTest_TouchEventState_Test::TestBody
*!testing::internal::HandleExceptionsInMethodIfSupported<>
}
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%284%29/builds/40143/steps/memory%20test%3A%20content/logs/stdio
UninitCondition
Conditional jump or move depends on uninitialised value(s)
content::TouchEventQueue::TouchMoveSlopSuppressor::FilterEvent(blink::WebTouchEvent const&) (content/browser/renderer_host/input/touch_event_queue.cc:240)
content::TouchEventQueue::FilterBeforeForwarding(blink::WebTouchEvent const&) (content/browser/renderer_host/input/touch_event_queue.cc:715)
content::TouchEventQueue::TryForwardNextEventToRenderer() (content/browser/renderer_host/input/touch_event_queue.cc:445)
content::TouchEventQueue::ProcessTouchAck(content::InputEventAckState, ui::LatencyInfo const&) (content/browser/renderer_host/input/touch_event_queue.cc:436)
content::InputRouterImpl::ProcessTouchAck(content::InputEventAckState, ui::LatencyInfo const&) (content/browser/renderer_host/input/input_router_impl.cc:666)
content::InputRouterImpl::ProcessInputEventAck(blink::WebInputEvent::Type, content::InputEventAckState, ui::LatencyInfo const&, content::InputRouterImpl::AckSource) (content/browser/renderer_host/input/input_router_impl.cc:576)
content::InputRouterImpl::OnInputEventAck(InputHostMsg_HandleInputEvent_ACK_Params const&) (content/browser/renderer_host/input/input_router_impl.cc:483)
_Z20DispatchToMethodImplIN7content15InputRouterImplEMS1_FvRK40InputHostMsg_HandleInputEvent_ACK_ParamsEJS2_EJLm0EEEvPT_T0_RK5TupleIJDpT1_EE13IndexSequenceIJXspT2_EEE (base/tuple.h:246)
Suppression (error hash=#675E7177BFE2BE12#):
For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports
{
<insert_a_suppression_name_here>
Memcheck:Uninitialized
fun:_ZN7content15TouchEventQueue23TouchMoveSlopSuppressor11FilterEventERKN5blink13WebTouchEventE
fun:_ZN7content15TouchEventQueue22FilterBeforeForwardingERKN5blink13WebTouchEventE
fun:_ZN7content15TouchEventQueue29TryForwardNextEventToRendererEv
fun:_ZN7content15TouchEventQueue15ProcessTouchAckENS_18InputEventAckStateERKN2ui11LatencyInfoE
fun:_ZN7content15InputRouterImpl15ProcessTouchAckENS_18InputEventAckStateERKN2ui11LatencyInfoE
fun:_ZN7content15InputRouterImpl20ProcessInputEventAckEN5blink13WebInputEvent4TypeENS_18InputEventAckStateERKN2ui11LatencyInfoENS0_9AckSourceE
fun:_ZN7content15InputRouterImpl15OnInputEventAckERK40InputHostMsg_HandleInputEvent_ACK_Params
fun:_Z20DispatchToMethodImplIN7content15InputRouterImplEMS1_FvRK40InputHostMsg_HandleInputEvent_ACK_ParamsEJS2_EJLm0EEEvPT_T0_RK5TupleIJDpT1_EE13IndexSequenceIJXspT2_EEE
}
I haven't been able to reproduce this consistently locally, which is making it tricky to pin down. Once I have (or I've determined this patch isn't what's causing the failures), I'll reland.
Original issue's description:
> Don't refcount tracking id -> slot id mapping.
>
> Previously we tried to refcount the tracking id to slot id mapping.
> This broke in some circumstances where the number of press events was
> not equal to the number of release events.
>
> This patch switches to marking some touch events such that they don't
> modify the mapping, simplifying logic, and fixing a nasty bug.
>
> BUG=439051
> TEST=EventsXTest.TouchEventNotRemovingFromNativeMapping
>
> Committed: https://crrev.com/47a823b565a4051e58d83a857738c0fb8417d9ac
> Cr-Commit-Position: refs/heads/master@{#313520}
TBR=sadrul@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=439051
Committed: https://crrev.com/3513587cce08b0b7ac35f16d5ca1dd8d30b02708
Cr-Commit-Position: refs/heads/master@{#313697}
Patch Set 1 #
Created: 5 years, 10 months ago
(Patch set is too large to download)
Messages
Total messages: 5 (0 generated)
|