Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: ui/views/controls/menu/menu_controller_unittest.cc

Issue 869433007: Revert of Don't refcount tracking id -> slot id mapping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/x/events_x_unittest.cc ('k') | ui/views/controls/menu/menu_event_dispatcher_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/menu/menu_controller_unittest.cc
diff --git a/ui/views/controls/menu/menu_controller_unittest.cc b/ui/views/controls/menu/menu_controller_unittest.cc
index 17457d98ccd42f428d20bb06c9a7b513a5b58836..381f489d716904e9f89445d1505420ea516a73bc 100644
--- a/ui/views/controls/menu/menu_controller_unittest.cc
+++ b/ui/views/controls/menu/menu_controller_unittest.cc
@@ -7,7 +7,6 @@
#include "base/run_loop.h"
#include "ui/aura/scoped_window_targeter.h"
#include "ui/aura/window.h"
-#include "ui/events/event_handler.h"
#include "ui/events/event_targeter.h"
#include "ui/events/platform/platform_event_source.h"
#include "ui/views/controls/menu/menu_item_view.h"
@@ -185,14 +184,6 @@
event_source_.Dispatch(key_event);
EXPECT_EQ(exit_type, controller_->exit_type());
controller_->exit_type_ = MenuController::EXIT_ALL;
- DispatchEvent();
- }
-
- void DispatchTouch(int evtype, int id) {
- ui::ScopedXI2Event touch_event;
- std::vector<ui::Valuator> valuators;
- touch_event.InitTouchEvent(1, evtype, id, gfx::Point(10, 10), valuators);
- event_source_.Dispatch(touch_event);
DispatchEvent();
}
#endif
@@ -275,64 +266,4 @@
}
#endif
-#if defined(USE_X11)
-
-class TestEventHandler : public ui::EventHandler {
- public:
- TestEventHandler() : outstanding_touches_(0) {}
-
- void OnTouchEvent(ui::TouchEvent* event) override {
- switch(event->type()) {
- case ui::ET_TOUCH_PRESSED:
- outstanding_touches_++;
- break;
- case ui::ET_TOUCH_RELEASED:
- case ui::ET_TOUCH_CANCELLED:
- outstanding_touches_--;
- break;
- default:
- break;
- }
- }
-
- int outstanding_touches() const { return outstanding_touches_; }
-
- private:
- int outstanding_touches_;
-};
-
-// Tests that touch event ids are released correctly. See
-// crbug.com/439051 for details. When the ids aren't managed
-// correctly, we get stuck down touches.
-TEST_F(MenuControllerTest, TouchIdsReleasedCorrectly) {
- scoped_ptr<Widget> owner(CreateOwnerWidget());
- TestEventHandler test_event_handler;
- owner->GetNativeWindow()->GetRootWindow()->AddPreTargetHandler(
- &test_event_handler);
-
- std::vector<unsigned int> devices;
- devices.push_back(1);
- ui::SetUpTouchDevicesForTest(devices);
-
- DispatchTouch(XI_TouchBegin, 0);
- DispatchTouch(XI_TouchBegin, 1);
- DispatchTouch(XI_TouchEnd, 0);
-
- message_loop()->PostTask(FROM_HERE,
- base::Bind(&MenuControllerTest::DispatchTouch,
- base::Unretained(this), XI_TouchEnd, 1));
-
- message_loop()->PostTask(
- FROM_HERE,
- base::Bind(&MenuControllerTest::DispatchEscapeAndExpect,
- base::Unretained(this), MenuController::EXIT_OUTERMOST));
-
- RunMenu(owner.get());
- EXPECT_EQ(0, test_event_handler.outstanding_touches());
-
- owner->GetNativeWindow()->GetRootWindow()->RemovePreTargetHandler(
- &test_event_handler);
-}
-#endif // defined(USE_X11)
-
} // namespace views
« no previous file with comments | « ui/events/x/events_x_unittest.cc ('k') | ui/views/controls/menu/menu_event_dispatcher_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698