Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 869433004: Pngcrush version determined correctly. (Closed)

Created:
5 years, 10 months ago by dzhioev (left Google)
Modified:
5 years, 10 months ago
Reviewers:
oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pngcrush version determined correctly. 'pngcrush -v' writes to stderr. Redirected stderr to stdout. BUG=none TEST=manually Committed: https://crrev.com/73bf3e533652079930114ce8b455032c01b9af68 Cr-Commit-Position: refs/heads/master@{#314153}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/resources/optimize-png-files.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dzhioev (left Google)
Hi, please review.
5 years, 10 months ago (2015-01-28 15:21:35 UTC) #2
oshima
lgtm
5 years, 10 months ago (2015-01-30 19:30:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869433004/1
5 years, 10 months ago (2015-02-02 15:08:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 16:00:35 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 16:02:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73bf3e533652079930114ce8b455032c01b9af68
Cr-Commit-Position: refs/heads/master@{#314153}

Powered by Google App Engine
This is Rietveld 408576698