tools/resources/optimize-png-files.sh - Issue 869433004: Pngcrush version determined correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/resources/optimize-png-files.sh

Issue 869433004: Pngcrush version determined correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/resources/optimize-png-files.sh

diff --git a/tools/resources/optimize-png-files.sh b/tools/resources/optimize-png-files.sh

index c7b37d73777cef59d3b2ec44d7983ea115b43946..c3d0a9ac655e4ad4865e59f025d4aa14de20fd12 100755

--- a/tools/resources/optimize-png-files.sh

+++ b/tools/resources/optimize-png-files.sh

@@ -384,7 +384,7 @@ function fail_if_not_installed {

# Check pngcrush version and exit if the version is in bad range.

# See crbug.com/404893.

function exit_if_bad_pngcrush_version {

- local version=$(pngcrush -v | awk "/pngcrush 1.7./ {print \$3}")

+ local version=$(pngcrush -v 2>&1 | awk "/pngcrush 1.7./ {print \$3}")

local version_num=$(echo $version | sed "s/\.//g")

if [[ (1748 -lt $version_num && $version_num -lt 1773) ]] ; then

echo "Your pngcrush ($version) has a bug that exists from " \

« no previous file with comments | « no previous file | no next file » | no next file with comments »