Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 869433002: Make single-click autofill default on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/autofill_agent.cc
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc
index 2c48d11bd60520134cfd5c5f5539c0ac1f40105e..e68eb69447588acde44cc9460665c22758cea297 100644
--- a/components/autofill/content/renderer/autofill_agent.cc
+++ b/components/autofill/content/renderer/autofill_agent.cc
@@ -309,8 +309,17 @@ void AutofillAgent::FormControlElementClicked(
options.display_warning_if_disabled = true;
options.show_full_suggestion_list = element.isAutofilled();
- if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableSingleClickAutofill)) {
+#if defined(OS_ANDROID)
brettw 2015/01/22 01:43:48 Can you add a quick comment about why the default
Evan Stade 2015/01/22 23:09:46 added link to bug and description in bug
+ bool single_click_autofill =
+ !base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kDisableSingleClickAutofill);
+#else
+ bool single_click_autofill =
+ base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kEnableSingleClickAutofill);
+#endif
+
+ if (!single_click_autofill) {
// Show full suggestions when clicking on an already-focused form field. On
// the initial click (not focused yet), only show password suggestions.
#if defined(OS_ANDROID)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698