Make single-click autofill default on Android

components/autofill/content/renderer/autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_split.h"
@@ skipping 291 matching lines @@
 
   const WebInputElement* input_element = toWebInputElement(&element);
   if (!input_element && !IsTextAreaElement(element))
     return;
 
   ShowSuggestionsOptions options;
   options.autofill_on_empty_values = true;
   options.display_warning_if_disabled = true;
   options.show_full_suggestion_list = element.isAutofilled();
 
-  if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
-          switches::kEnableSingleClickAutofill)) {
+#if defined(OS_ANDROID)

[brettw, 2015/01/22 01:43:48]

Can you add a quick comment about why the default is different on Android for
now?

[Evan Stade, 2015/01/22 23:09:46]

added link to bug and description in bug

+  bool single_click_autofill =
+      !base::CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kDisableSingleClickAutofill);
+#else
+  bool single_click_autofill =
+      base::CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kEnableSingleClickAutofill);
+#endif
+
+  if (!single_click_autofill) {
     // Show full suggestions when clicking on an already-focused form field. On
     // the initial click (not focused yet), only show password suggestions.
 #if defined(OS_ANDROID)
     // TODO(gcasto): Remove after crbug.com/430318 has been fixed.
     if (!was_focused)
       return;
 #endif
 
     options.show_full_suggestion_list =
         options.show_full_suggestion_list || was_focused;
@@ skipping 453 matching lines @@
 void AutofillAgent::LegacyAutofillAgent::OnDestruct() {
   // No-op. Don't delete |this|.
 }
 
 void AutofillAgent::LegacyAutofillAgent::FocusedNodeChanged(
     const WebNode& node) {
   agent_->FocusedNodeChanged(node);
 }
 
 }  // namespace autofill