Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 869433002: Make single-click autofill default on Android (Closed)

Created:
5 years, 11 months ago by Evan Stade
Modified:
5 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make single-click autofill default on Android BUG=427660 Committed: https://crrev.com/354304bc08fc693965750b27070e59bee364a922 Cr-Commit-Position: refs/heads/master@{#312727}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +11 lines, -2 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
Evan Stade
5 years, 11 months ago (2015-01-22 00:16:10 UTC) #2
brettw
lgtm https://codereview.chromium.org/869433002/diff/1/components/autofill/content/renderer/autofill_agent.cc File components/autofill/content/renderer/autofill_agent.cc (right): https://codereview.chromium.org/869433002/diff/1/components/autofill/content/renderer/autofill_agent.cc#newcode312 components/autofill/content/renderer/autofill_agent.cc:312: #if defined(OS_ANDROID) Can you add a quick comment ...
5 years, 11 months ago (2015-01-22 01:43:48 UTC) #3
Evan Stade
https://codereview.chromium.org/869433002/diff/1/components/autofill/content/renderer/autofill_agent.cc File components/autofill/content/renderer/autofill_agent.cc (right): https://codereview.chromium.org/869433002/diff/1/components/autofill/content/renderer/autofill_agent.cc#newcode312 components/autofill/content/renderer/autofill_agent.cc:312: #if defined(OS_ANDROID) On 2015/01/22 01:43:48, brettw wrote: > Can ...
5 years, 11 months ago (2015-01-22 23:09:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869433002/1
5 years, 11 months ago (2015-01-23 00:20:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 01:20:56 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 01:22:26 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/354304bc08fc693965750b27070e59bee364a922
Cr-Commit-Position: refs/heads/master@{#312727}

Powered by Google App Engine
This is Rietveld 408576698