Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 869193004: <webview>: Reuse GuestViewBase::HandleKeyboardEvent code. (Closed)

Created:
5 years, 11 months ago by Fady Samuel
Modified:
5 years, 11 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

<webview>: Reuse GuestViewBase::HandleKeyboardEvent code. <webview> has its own implementation of HandleKeyboardEvent that deals with back/forward keys and so on but for keys it doesn't know how to handle, it should pass them along as other GuestViews do. This CL also moves WebContentsObserver and WebContentsDelegate overrides in GuestViewBase from private to protected. BUG=none Committed: https://crrev.com/4a1650ffd40fb4b042d2004b938f2442ccafcec9 Cr-Commit-Position: refs/heads/master@{#312938}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -31 lines) Patch
M extensions/browser/guest_view/guest_view_base.h View 2 chunks +20 lines, -20 lines 2 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Fady Samuel
5 years, 11 months ago (2015-01-23 19:55:22 UTC) #2
lazyboy
lgtm https://codereview.chromium.org/869193004/diff/1/extensions/browser/guest_view/guest_view_base.h File extensions/browser/guest_view/guest_view_base.h (right): https://codereview.chromium.org/869193004/diff/1/extensions/browser/guest_view/guest_view_base.h#newcode299 extensions/browser/guest_view/guest_view_base.h:299: // WebContentsObserver implementation. Also note this private->public changes ...
5 years, 11 months ago (2015-01-23 20:08:01 UTC) #3
Fady Samuel
https://codereview.chromium.org/869193004/diff/1/extensions/browser/guest_view/guest_view_base.h File extensions/browser/guest_view/guest_view_base.h (right): https://codereview.chromium.org/869193004/diff/1/extensions/browser/guest_view/guest_view_base.h#newcode299 extensions/browser/guest_view/guest_view_base.h:299: // WebContentsObserver implementation. On 2015/01/23 20:08:01, lazyboy wrote: > ...
5 years, 11 months ago (2015-01-23 20:13:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869193004/1
5 years, 11 months ago (2015-01-23 20:14:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 21:58:22 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 21:59:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a1650ffd40fb4b042d2004b938f2442ccafcec9
Cr-Commit-Position: refs/heads/master@{#312938}

Powered by Google App Engine
This is Rietveld 408576698