<webview>: Reuse GuestViewBase::HandleKeyboardEvent code.

extensions/browser/guest_view/guest_view_base.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_BASE_H_
 #define EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_BASE_H_
 
 #include <queue>
 
 #include "base/memory/weak_ptr.h"
@@ skipping 278 matching lines @@
 
   // Dispatches an event to the view.
   void DispatchEventToView(Event* event);
 
  protected:
   GuestViewBase(content::WebContents* owner_web_contents,
                 int guest_instance_id);
 
   ~GuestViewBase() override;
 
+  // WebContentsObserver implementation.

[lazyboy, 2015/01/23 20:08:01]

Also note this private->public changes to overridden methods in the CL
description.

[Fady Samuel, 2015/01/23 20:13:22]

Done. CQ'ing now.

+  void DidStopLoading(content::RenderViewHost* render_view_host) final;
+  void RenderViewReady() final;
+  void WebContentsDestroyed() final;
+
+  // WebContentsDelegate implementation.
+  void ActivateContents(content::WebContents* contents) final;
+  void DeactivateContents(content::WebContents* contents) final;
+  void ContentsZoomChange(bool zoom_in) override;
+  void HandleKeyboardEvent(
+      content::WebContents* source,
+      const content::NativeWebKeyboardEvent& event) override;
+  void RunFileChooser(content::WebContents* web_contents,
+                      const content::FileChooserParams& params) override;
+  bool ShouldFocusPageAfterCrash() final;
+  bool PreHandleGestureEvent(content::WebContents* source,
+                             const blink::WebGestureEvent& event) final;
+  void UpdatePreferredSize(content::WebContents* web_contents,
+                           const gfx::Size& pref_size) final;
+
  private:
   class OwnerLifetimeObserver;
 
   class OpenerLifetimeObserver;
 
   void DispatchEvent(Event* event, int instance_id);
 
   void SendQueuedEvents();
 
   void CompleteInit(scoped_ptr<base::DictionaryValue> create_params,
                     const WebContentsCreatedCallback& callback,
                     content::WebContents* guest_web_contents);
 
   // Dispatches the onResize event to the embedder.
   void DispatchOnResizeEvent(const gfx::Size& old_size,
                              const gfx::Size& new_size);
 
   void SetUpSizing(const base::DictionaryValue& params);
 
   void StartTrackingEmbedderZoomLevel();
   void StopTrackingEmbedderZoomLevel();
 
   static void RegisterGuestViewTypes();
 
-  // WebContentsObserver implementation.
-  void DidStopLoading(content::RenderViewHost* render_view_host) final;
-  void RenderViewReady() final;
-  void WebContentsDestroyed() final;
-
-  // WebContentsDelegate implementation.
-  void ActivateContents(content::WebContents* contents) final;
-  void DeactivateContents(content::WebContents* contents) final;
-  void ContentsZoomChange(bool zoom_in) override;
-  void HandleKeyboardEvent(
-      content::WebContents* source,
-      const content::NativeWebKeyboardEvent& event) override;
-  void RunFileChooser(content::WebContents* web_contents,
-                      const content::FileChooserParams& params) override;
-  bool ShouldFocusPageAfterCrash() final;
-  bool PreHandleGestureEvent(content::WebContents* source,
-                             const blink::WebGestureEvent& event) final;
-  void UpdatePreferredSize(content::WebContents* web_contents,
-                           const gfx::Size& pref_size) final;
-
   // This guest tracks the lifetime of the WebContents specified by
   // |owner_web_contents_|. If |owner_web_contents_| is destroyed then this
   // guest will also self-destruct.
   content::WebContents* owner_web_contents_;
   std::string owner_extension_id_;
   content::BrowserContext* const browser_context_;
 
   // |guest_instance_id_| is a profile-wide unique identifier for a guest
   // WebContents.
   const int guest_instance_id_;
@@ skipping 61 matching lines @@
   // This is used to ensure pending tasks will not fire after this object is
   // destroyed.
   base::WeakPtrFactory<GuestViewBase> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(GuestViewBase);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_BASE_H_