Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2345)

Issue 869173002: VTTCue: Remove dead exception throwing code in setLine/setPosition (Closed)

Created:
5 years, 11 months ago by fs
Modified:
5 years, 11 months ago
CC:
philipj_slow, arv+blink, blink-reviews, blink-reviews-html_chromium.org, Inactive, dglazkov+blink, eric.carlson_apple.com, fs, gasubic, nessy, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

VTTCue: Remove dead exception throwing code in setLine/setPosition After https://codereview.chromium.org/860353002, these checks should be handled by the generated bindings code. TEST=media/track/opera/interfaces/VTTCue/{line,position}.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188884

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M Source/core/html/track/vtt/VTTCue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTCue.cpp View 2 chunks +1 line, -13 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
fs
PTAL
5 years, 11 months ago (2015-01-23 12:40:22 UTC) #2
Jens Widell
LGTM
5 years, 11 months ago (2015-01-23 12:59:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869173002/1
5 years, 11 months ago (2015-01-23 13:09:31 UTC) #5
commit-bot: I haz the power
Failed to commit the patch. svn: E155010: Commit failed (details follow): svn: E155010: '/b/infra_internal/commit_queue/workdir/blink/LayoutTests/fast/multicol/dynamic' is ...
5 years, 11 months ago (2015-01-23 13:31:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869173002/1
5 years, 11 months ago (2015-01-23 13:37:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=188884
5 years, 11 months ago (2015-01-23 13:38:19 UTC) #10
philipj_slow
5 years, 11 months ago (2015-01-25 12:48:49 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698