Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: Source/core/html/track/vtt/VTTCue.cpp

Issue 869173002: VTTCue: Remove dead exception throwing code in setLine/setPosition (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/track/vtt/VTTCue.h ('k') | Source/core/html/track/vtt/VTTCue.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/vtt/VTTCue.cpp
diff --git a/Source/core/html/track/vtt/VTTCue.cpp b/Source/core/html/track/vtt/VTTCue.cpp
index fa09bd03d570112a3eb16582db9ec5bfc24e0f0f..5537c2b3b2e533a8ab1bfc6ba5280d954cc39895 100644
--- a/Source/core/html/track/vtt/VTTCue.cpp
+++ b/Source/core/html/track/vtt/VTTCue.cpp
@@ -328,14 +328,8 @@ void VTTCue::line(DoubleOrAutoKeyword& result) const
result.setDouble(m_linePosition);
}
-void VTTCue::setLine(const DoubleOrAutoKeyword& position, ExceptionState& exceptionState)
+void VTTCue::setLine(const DoubleOrAutoKeyword& position)
{
- // FIXME: Expecting bindings code to handle this case: https://crbug.com/450252.
- if (position.isDouble() && !std::isfinite(position.getAsDouble())) {
- exceptionState.throwTypeError("The provided double value is non-finite.");
- return;
- }
-
// http://dev.w3.org/html5/webvtt/#dfn-vttcue-line
// On setting, the text track cue line position must be set to the new
// value; if the new value is the string "auto", then it must be
@@ -374,12 +368,6 @@ void VTTCue::position(DoubleOrAutoKeyword& result) const
void VTTCue::setPosition(const DoubleOrAutoKeyword& position, ExceptionState& exceptionState)
{
- // FIXME: Expecting bindings code to handle this case: https://crbug.com/450252.
- if (position.isDouble() && !std::isfinite(position.getAsDouble())) {
- exceptionState.throwTypeError("The provided double value is non-finite.");
- return;
- }
-
// http://dev.w3.org/html5/webvtt/#dfn-vttcue-position
// On setting, if the new value is negative or greater than 100, then an
// IndexSizeError exception must be thrown. Otherwise, the text track cue
« no previous file with comments | « Source/core/html/track/vtt/VTTCue.h ('k') | Source/core/html/track/vtt/VTTCue.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698