Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7805)

Unified Diff: chrome/test/chromedriver/net/websocket.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: One more chromeos-specific fix. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/net/websocket.cc
diff --git a/chrome/test/chromedriver/net/websocket.cc b/chrome/test/chromedriver/net/websocket.cc
index 76d17dac75356fba955f9a6ab0defef45ef1feee..2c214f9c1494c96cc0b95ef4f8b2ad901b5058b4 100644
--- a/chrome/test/chromedriver/net/websocket.cc
+++ b/chrome/test/chromedriver/net/websocket.cc
@@ -121,7 +121,7 @@ void WebSocket::OnSocketConnect(int code) {
return;
}
- CHECK(base::Base64Encode(base::RandBytesAsString(16), &sec_key_));
+ base::Base64Encode(base::RandBytesAsString(16), &sec_key_);
std::string handshake = base::StringPrintf(
"GET %s HTTP/1.1\r\n"
"Host: %s\r\n"
@@ -210,8 +210,8 @@ void WebSocket::OnReadDuringHandshake(const char* data, int len) {
const char kMagicKey[] = "258EAFA5-E914-47DA-95CA-C5AB0DC85B11";
std::string websocket_accept;
- CHECK(base::Base64Encode(base::SHA1HashString(sec_key_ + kMagicKey),
- &websocket_accept));
+ base::Base64Encode(base::SHA1HashString(sec_key_ + kMagicKey),
+ &websocket_accept);
scoped_refptr<net::HttpResponseHeaders> headers(
new net::HttpResponseHeaders(
net::HttpUtil::AssembleRawHeaders(
@@ -262,5 +262,3 @@ void WebSocket::Close(int code) {
state_ = CLOSED;
}
-
-
« no previous file with comments | « chrome/test/chromedriver/chrome_launcher_unittest.cc ('k') | components/policy/core/common/cloud/resource_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698