jingle/notifier/listener/push_notifications_send_update_task_unittest.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: jingle/notifier/listener/push_notifications_send_update_task_unittest.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« google_apis/gaia/oauth_request_signer.cc ('K') | « jingle/notifier/listener/push_notifications_send_update_task.cc ('k') | net/base/keygen_handler_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: jingle/notifier/listener/push_notifications_send_update_task_unittest.cc

diff --git a/jingle/notifier/listener/push_notifications_send_update_task_unittest.cc b/jingle/notifier/listener/push_notifications_send_update_task_unittest.cc

index c57bd93c2dae8ee15a84dac88e916ed8a6d9a398..0395352879dccb3661b3e639e6d68d4736f45e9d 100644

--- a/jingle/notifier/listener/push_notifications_send_update_task_unittest.cc

+++ b/jingle/notifier/listener/push_notifications_send_update_task_unittest.cc

@@ -36,7 +36,7 @@ TEST_F(PushNotificationsSendUpdateTaskTest, MakeUpdateMessage) {

notification.data = "test_data";

std::string base64_data;

- EXPECT_TRUE(base::Base64Encode(notification.data, &base64_data));

+ base::Base64Encode(notification.data, &base64_data);

scoped_ptr<buzz::XmlElement> message(

PushNotificationsSendUpdateTask::MakeUpdateMessage(

« google_apis/gaia/oauth_request_signer.cc ('K') | « jingle/notifier/listener/push_notifications_send_update_task.cc ('k') | net/base/keygen_handler_win.cc » ('j') | no next file with comments »