Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: jingle/notifier/listener/push_notifications_send_update_task.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebase. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: jingle/notifier/listener/push_notifications_send_update_task.cc
diff --git a/jingle/notifier/listener/push_notifications_send_update_task.cc b/jingle/notifier/listener/push_notifications_send_update_task.cc
index 4e0c12782adc880bdcb45a56b625490860d4568f..9b5abb6fd3ddcbd6fb0c0f6c45a3fe5fe450544c 100644
--- a/jingle/notifier/listener/push_notifications_send_update_task.cc
+++ b/jingle/notifier/listener/push_notifications_send_update_task.cc
@@ -71,20 +71,14 @@ buzz::XmlElement* PushNotificationsSendUpdateTask::MakeUpdateMessage(
recipient_element->AddAttr(buzz::QN_TO, recipient.to);
if (!recipient.user_specific_data.empty()) {
std::string base64_data;
- if (!base::Base64Encode(recipient.user_specific_data, &base64_data)) {
- DLOG(WARNING) << "Could not encode data "
- << recipient.user_specific_data;
- } else {
- recipient_element->SetBodyText(base64_data);
- }
+ base::Base64Encode(recipient.user_specific_data, &base64_data);
+ recipient_element->SetBodyText(base64_data);
}
}
buzz::XmlElement* data = new buzz::XmlElement(kQnData, true);
std::string base64_data;
- if (!base::Base64Encode(notification.data, &base64_data)) {
- DLOG(WARNING) << "Could not encode data " << notification.data;
- }
+ base::Base64Encode(notification.data, &base64_data);
data->SetBodyText(base64_data);
push->AddElement(data);

Powered by Google App Engine
This is Rietveld 408576698