base/base64.h - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/base64.h

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/base64.h

diff --git a/base/base64.h b/base/base64.h

index cc78edce5c6eebdde84dd81eaab41bc0ecf526a1..bc6a39f36c4450593d0ecfc60c7ed4f5c6148b1d 100644

--- a/base/base64.h

+++ b/base/base64.h

@@ -12,8 +12,7 @@

namespace base {

-// Encodes the input string in base64. Returns true if successful and false

-// otherwise. The output string is only modified if successful.

+// Encodes the input string in base64. Returns true.

BASE_EXPORT bool Base64Encode(const StringPiece& input, std::string* output);

brettw 2013/12/05 06:33:57 It seems like we should just fix the return value

// Decodes the base64 input string. Returns true if successful and false

« no previous file with comments | « no previous file | base/base64.cc » ('j') | no next file with comments »