Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 869043008: Reland of Move tracing namespace from base::debug to base::trace_event. (Closed)

Created:
5 years, 10 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 10 months ago
Reviewers:
dsinclair, jam, Sami, ssid
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, wfh+watch_chromium.org, jam, dsinclair+watch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, cc-bugs_chromium.org, erikwright+watch_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Move tracing namespace from base::debug to base::trace_event. Original CL: crrev.com/882673002 Reason for revert: Broke memory.fyi bot (crbug.com/455530) Reason for reland: The CL was renaming the tracing namespace and missed the rename of the tsan suppression (addressed here) Original description: After having transitioned all the tracing headers from base/debug/ to base/trace_event, this CL addresses the namespace move. In principle, this CL should only change the namespace of the base/trace_event files but the namespace used by the tracing clients. In order to achieve this, namespace aliases are appended to the trace_event headers, to make it so that clients can still refer to base::debug::TraceFoo, with that being aliased to base::trace_event::TraceFoo. The upcoming CLs will gradually migrate the clients to use the base::trace_event namespace and will remove the ns aliases. Unfortunately, this CL has also to update few tracing clients, in particular the ones having forward declarations. Forward declarations, in fact, cannot be aliased as the compiler sees them before the alias itself. See crrev.com/837303004 and the related bug for motivations and design doc. BUG=451032, 455530 TBR=skyostil@chromium.org,jam@chromium.org,dsinclair@chromium.org,ssid@chromium.org Committed: https://crrev.com/159604379ff8ef8d3db4577f44d3d6438092ccf0 Cr-Commit-Position: refs/heads/master@{#314806}

Patch Set 1 #

Patch Set 2 : Fix suppressions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+398 lines, -148 lines) Patch
M base/trace_event/trace_event.h View 26 chunks +57 lines, -41 lines 0 comments Download
M base/trace_event/trace_event_android.cc View 6 chunks +9 lines, -8 lines 0 comments Download
M base/trace_event/trace_event_argument.h View 2 chunks +9 lines, -1 line 0 comments Download
M base/trace_event/trace_event_argument.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_argument_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_impl.h View 3 chunks +21 lines, -4 lines 0 comments Download
M base/trace_event/trace_event_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M base/trace_event/trace_event_impl_constants.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_memory.h View 4 chunks +4 lines, -4 lines 0 comments Download
M base/trace_event/trace_event_memory.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M base/trace_event/trace_event_memory_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_synthetic_delay.h View 3 chunks +4 lines, -4 lines 0 comments Download
M base/trace_event/trace_event_synthetic_delay.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M base/trace_event/trace_event_synthetic_delay_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_system_stats_monitor.h View 3 chunks +3 lines, -3 lines 0 comments Download
M base/trace_event/trace_event_system_stats_monitor.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M base/trace_event/trace_event_system_stats_monitor_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M base/trace_event/trace_event_win.h View 2 chunks +15 lines, -1 line 0 comments Download
M base/trace_event/trace_event_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M build/sanitizers/tsan_suppressions.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M cc/base/math_util.h View 1 chunk +7 lines, -1 line 0 comments Download
M cc/base/region.h View 1 chunk +7 lines, -1 line 0 comments Download
M cc/blink/web_layer_impl.h View 1 chunk +7 lines, -1 line 0 comments Download
M cc/debug/traced_value.h View 1 chunk +7 lines, -1 line 0 comments Download
M cc/layers/layer.h View 1 chunk +7 lines, -1 line 0 comments Download
M cc/layers/layer_client.h View 1 chunk +7 lines, -1 line 0 comments Download
M cc/layers/layer_impl.h View 1 chunk +8 lines, -2 lines 0 comments Download
M cc/output/begin_frame_args.h View 1 chunk +8 lines, -1 line 0 comments Download
M cc/output/filter_operation.h View 1 chunk +8 lines, -2 lines 0 comments Download
M cc/output/filter_operations.h View 1 chunk +8 lines, -2 lines 0 comments Download
M cc/quads/draw_quad.h View 1 chunk +8 lines, -2 lines 0 comments Download
M cc/quads/render_pass.h View 1 chunk +8 lines, -2 lines 0 comments Download
M cc/quads/shared_quad_state.h View 1 chunk +7 lines, -1 line 0 comments Download
M cc/resources/bitmap_tile_task_worker_pool.h View 1 chunk +7 lines, -1 line 0 comments Download
M cc/resources/one_copy_tile_task_worker_pool.h View 1 chunk +8 lines, -1 line 0 comments Download
M cc/resources/picture_layer_tiling.h View 1 chunk +7 lines, -1 line 0 comments Download
M cc/resources/picture_layer_tiling_set.h View 1 chunk +7 lines, -1 line 0 comments Download
M cc/resources/pixel_buffer_tile_task_worker_pool.h View 1 chunk +8 lines, -1 line 0 comments Download
M cc/resources/tile_manager.h View 1 chunk +8 lines, -1 line 0 comments Download
M cc/resources/zero_copy_tile_task_worker_pool.h View 1 chunk +7 lines, -1 line 0 comments Download
M cc/scheduler/delay_based_time_source.h View 1 chunk +8 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler.h View 1 chunk +8 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler_settings.h View 1 chunk +7 lines, -1 line 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 1 chunk +9 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +7 lines, -1 line 0 comments Download
M cc/trees/proxy.h View 1 chunk +8 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.h View 1 chunk +8 lines, -1 line 0 comments Download
M content/child/child_thread_impl.h View 1 chunk +7 lines, -1 line 0 comments Download
M content/renderer/scheduler/renderer_scheduler_impl.h View 1 chunk +7 lines, -1 line 0 comments Download
M content/renderer/scheduler/task_queue_manager.h View 1 chunk +8 lines, -1 line 0 comments Download
M content/renderer/scheduler/task_queue_selector.h View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869043008/20001
5 years, 10 months ago (2015-02-05 12:08:02 UTC) #2
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 14:20:55 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 14:21:59 UTC) #4
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/159604379ff8ef8d3db4577f44d3d6438092ccf0
Cr-Commit-Position: refs/heads/master@{#314806}

Powered by Google App Engine
This is Rietveld 408576698