Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Side by Side Diff: cc/output/begin_frame_args.h

Issue 869043008: Reland of Move tracing namespace from base::debug to base::trace_event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Fix suppressions Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/layers/layer_impl.h ('k') | cc/output/filter_operation.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_OUTPUT_BEGIN_FRAME_ARGS_H_ 5 #ifndef CC_OUTPUT_BEGIN_FRAME_ARGS_H_
6 #define CC_OUTPUT_BEGIN_FRAME_ARGS_H_ 6 #define CC_OUTPUT_BEGIN_FRAME_ARGS_H_
7 7
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
11 #include "base/values.h" 11 #include "base/values.h"
12 #include "cc/base/cc_export.h" 12 #include "cc/base/cc_export.h"
13 13
14 namespace base { 14 namespace base {
15 namespace debug { 15 namespace trace_event {
16 class ConvertableToTraceFormat; 16 class ConvertableToTraceFormat;
17 class TracedValue; 17 class TracedValue;
18 } 18 }
19
20 // TODO(ssid): remove these aliases after the tracing clients are moved to the
21 // new trace_event namespace. See crbug.com/451032. ETA: March 2015
22 namespace debug {
23 using ::base::trace_event::ConvertableToTraceFormat;
24 using ::base::trace_event::TracedValue;
19 } 25 }
26 } // namespace base
20 27
21 /** 28 /**
22 * In debug builds we trace the creation origin of BeginFrameArgs objects. We 29 * In debug builds we trace the creation origin of BeginFrameArgs objects. We
23 * reuse the tracked_objects::Location system to do that. 30 * reuse the tracked_objects::Location system to do that.
24 * 31 *
25 * However, in release builds we don't want this as it doubles the size of the 32 * However, in release builds we don't want this as it doubles the size of the
26 * BeginFrameArgs object. As well it adds a number of largish strings to the 33 * BeginFrameArgs object. As well it adds a number of largish strings to the
27 * binary. Despite the argument being unused, most compilers are unable to 34 * binary. Despite the argument being unused, most compilers are unable to
28 * optimise it away even when unused. Instead we use the BEGINFRAME_FROM_HERE 35 * optimise it away even when unused. Instead we use the BEGINFRAME_FROM_HERE
29 * macro to prevent the data even getting referenced. 36 * macro to prevent the data even getting referenced.
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 private: 95 private:
89 BeginFrameArgs(base::TimeTicks frame_time, 96 BeginFrameArgs(base::TimeTicks frame_time,
90 base::TimeTicks deadline, 97 base::TimeTicks deadline,
91 base::TimeDelta interval, 98 base::TimeDelta interval,
92 BeginFrameArgsType type); 99 BeginFrameArgsType type);
93 }; 100 };
94 101
95 } // namespace cc 102 } // namespace cc
96 103
97 #endif // CC_OUTPUT_BEGIN_FRAME_ARGS_H_ 104 #endif // CC_OUTPUT_BEGIN_FRAME_ARGS_H_
OLDNEW
« no previous file with comments | « cc/layers/layer_impl.h ('k') | cc/output/filter_operation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698