Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 868973002: Don't set expression attributes before they're bound. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium, ojan
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Don't set expression attributes before they're bound. We were cloning elements with all the attributes that contained expressions like attrName="{{ foo }}" which meant we'd go through the reflection process converting that value and also call the attrNameChanged() callback and the attributeChanged() with the braced string which the element didn't really want to know about. After this patch we create a "clone source node" which is a copy of the original element without the attributes that have the expressions and use that when cloning, then we assign the properties using data binding later. R=abarth@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1a1e9bee08f42b600cb42a7e07c84618a837f977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -19 lines) Patch
M sky/examples/widgets/index.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/sky-element/element-registry.sky View 4 chunks +14 lines, -4 lines 0 comments Download
M sky/framework/sky-element/sky-binder.sky View 3 chunks +27 lines, -9 lines 0 comments Download
M sky/framework/sky-element/sky-element.sky View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/tests/framework/templates.sky View 2 chunks +24 lines, -0 lines 0 comments Download
M sky/tests/framework/templates-expected.txt View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
esprehn
5 years, 11 months ago (2015-01-23 00:33:03 UTC) #1
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-23 00:55:02 UTC) #2
ojan
lgtm
5 years, 11 months ago (2015-01-23 00:55:09 UTC) #4
esprehn
5 years, 11 months ago (2015-01-23 01:04:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a1e9bee08f42b600cb42a7e07c84618a837f977 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698