sky/framework/sky-element/sky-element.sky - Issue 868973002: Don't set expression attributes before they're bound.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/framework/sky-element/sky-element.sky

Issue 868973002: Don't set expression attributes before they're bound. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/framework/sky-element/sky-element.sky

diff --git a/sky/framework/sky-element/sky-element.sky b/sky/framework/sky-element/sky-element.sky

index ecbc9667e0574db0b2738384946845e6bcbb0583..07818bc21bb9183dd64cac621ad46106b523294a 100644

--- a/sky/framework/sky-element/sky-element.sky

+++ b/sky/framework/sky-element/sky-element.sky

@@ -133,6 +133,8 @@ class SkyElement extends HTMLElement {

}

attributeChangedCallback(name, oldValue, newValue) {

+ if (registry.isExpandableAttribute(name))

+ return;

this.attributeChanged(name, oldValue, newValue);

var registration = registry.getRegistration(this.localName);

var converter = registration.attributes.get(name);

« no previous file with comments | « sky/framework/sky-element/sky-binder.sky ('k') | sky/tests/framework/templates.sky » ('j') | no next file with comments »