Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 868953002: Remove unused QuicDecrypter::Decrypt method and implementations. (Closed)

Created:
5 years, 11 months ago by ramant (doing other things)
Modified:
5 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@merge_84442484
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused QuicDecrypter::Decrypt method and implementations. Merge internal change: 84548556 R=rch@chromium.org

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -95 lines) Patch
M net/quic/crypto/aead_base_decrypter.h View 2 chunks +6 lines, -5 lines 0 comments Download
M net/quic/crypto/aes_128_gcm_12_decrypter_test.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M net/quic/crypto/chacha20_poly1305_decrypter_test.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M net/quic/crypto/crypto_secret_boxer.cc View 2 chunks +13 lines, -6 lines 2 comments Download
M net/quic/crypto/null_decrypter.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/quic/crypto/null_decrypter.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M net/quic/crypto/quic_decrypter.h View 1 chunk +0 lines, -12 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M net/quic/quic_framer_test.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ramant (doing other things)
5 years, 11 months ago (2015-01-23 00:22:57 UTC) #1
Ryan Hamilton
lgtm https://codereview.chromium.org/868953002/diff/1/net/quic/crypto/crypto_secret_boxer.cc File net/quic/crypto/crypto_secret_boxer.cc (right): https://codereview.chromium.org/868953002/diff/1/net/quic/crypto/crypto_secret_boxer.cc#newcode103 net/quic/crypto/crypto_secret_boxer.cc:103: out->set(data, decrypted->length()); consider using out->assign(decrypted->data(), decrypted->length()) instead. (I ...
5 years, 11 months ago (2015-01-23 00:29:13 UTC) #2
ramant (doing other things)
5 years, 11 months ago (2015-01-23 00:47:54 UTC) #3 
https://codereview.chromium.org/868953002/diff/1/net/quic/crypto/crypto_secre...
File net/quic/crypto/crypto_secret_boxer.cc (right):

https://codereview.chromium.org/868953002/diff/1/net/quic/crypto/crypto_secre...
net/quic/crypto/crypto_secret_boxer.cc:103: out->set(data, decrypted->length());
On 2015/01/23 00:29:13, Ryan Hamilton wrote:
> consider using out->assign(decrypted->data(), decrypted->length()) instead. (I
> think that works)

Used std::string's assign to copy the data in the merged CL. Thanks Ryan.

https://codereview.chromium.org/868993002/diff2/1:20001/net/quic/crypto/crypt...

Done.

Powered by Google App Engine
This is Rietveld 408576698