Remove unused QuicDecrypter::Decrypt method and implementations.

net/quic/crypto/crypto_secret_boxer.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/crypto/crypto_secret_boxer.h"
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "net/quic/crypto/crypto_protocol.h"
 #include "net/quic/crypto/quic_decrypter.h"
@@ skipping 56 matching lines @@
   return ret;
 }
 
 bool CryptoSecretBoxer::Unbox(StringPiece ciphertext,
                               string* out_storage,
                               StringPiece* out) const {
   if (ciphertext.size() < kBoxNonceSize) {
     return false;
   }
 
-  char nonce[kBoxNonceSize];
-  memcpy(nonce, ciphertext.data(), kBoxNonceSize);
+  StringPiece nonce(ciphertext.data(), kBoxNonceSize);
   ciphertext.remove_prefix(kBoxNonceSize);
 
   size_t len = ciphertext.size();
   out_storage->resize(len);
   char* data = const_cast<char*>(out_storage->data());
 
   scoped_ptr<QuicDecrypter> decrypter(QuicDecrypter::Create(kAESG));
   if (!decrypter->SetKey(key_)) {
     DLOG(DFATAL) << "CryptoSecretBoxer's decrypter->SetKey failed.";
     return false;
   }
-  if (!decrypter->Decrypt(StringPiece(nonce, kBoxNonceSize), StringPiece(),
-                          ciphertext, reinterpret_cast<unsigned char*>(data),
-                          &len)) {
+
+  QuicPacketSequenceNumber sequence_number;
+  StringPiece nonce_prefix(nonce.data(),
+                           nonce.size() - sizeof(sequence_number));
+  decrypter->SetNoncePrefix(nonce_prefix);
+  memcpy(&sequence_number, nonce.data() + nonce_prefix.size(),
+         sizeof(sequence_number));
+  scoped_ptr<QuicData> decrypted(
+      decrypter->DecryptPacket(sequence_number, StringPiece(), ciphertext));
+  if (!decrypted.get()) {
     return false;
   }
 
-  out->set(data, len);
+  memcpy(data, decrypted->data(), decrypted->length());
+  out->set(data, decrypted->length());

[Ryan Hamilton, 2015/01/23 00:29:13]

consider using out->assign(decrypted->data(), decrypted->length()) instead. (I
think that works)

[ramant (doing other things), 2015/01/23 00:47:54]

Used std::string's assign to copy the data in the merged CL. Thanks Ryan.

https://codereview.chromium.org/868993002/diff2/1:20001/net/quic/crypto/crypt...

Done.

   return true;
 }
 
 }  // namespace net