Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 868933003: Remove user gesture tracking (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove user gesture tracking The developer has full control of Sky. We don't need to track whether something was caused by a user gesture. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0f45ef10f850bcde8e4f2b52945df046bc67da99

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -840 lines) Patch
M sky/engine/bindings/core/v8/ScriptController.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Element.cpp View 2 chunks +5 lines, -8 lines 2 comments Download
M sky/engine/core/frame/DOMTimer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/frame/DOMTimer.cpp View 4 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/Settings.in View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/loader/FrameLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/page/EventHandler.h View 4 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 9 chunks +2 lines, -32 lines 0 comments Download
M sky/engine/platform/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/engine/platform/UserGestureIndicator.h View 1 chunk +0 lines, -89 lines 0 comments Download
D sky/engine/platform/UserGestureIndicator.cpp View 1 chunk +0 lines, -230 lines 0 comments Download
M sky/engine/platform/exported/WebURLRequest.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/platform/network/ResourceRequest.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/platform/network/ResourceRequest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/public/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/public/platform/WebURLRequest.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/public/web/WebFrame.h View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/engine/public/web/WebScopedUserGesture.h View 1 chunk +0 lines, -70 lines 0 comments Download
M sky/engine/public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/public/web/WebUserGestureIndicator.h View 1 chunk +0 lines, -56 lines 0 comments Download
D sky/engine/public/web/WebUserGestureToken.h View 1 chunk +0 lines, -73 lines 0 comments Download
M sky/engine/web/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/web/FrameLoaderClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebFrame.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
D sky/engine/web/WebScopedUserGesture.cpp View 1 chunk +0 lines, -55 lines 0 comments Download
M sky/engine/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/engine/web/WebUserGestureIndicator.cpp View 1 chunk +0 lines, -54 lines 0 comments Download
D sky/engine/web/WebUserGestureToken.cpp View 1 chunk +0 lines, -73 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 3 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 6 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
5 years, 11 months ago (2015-01-22 23:47:45 UTC) #1
eseidel
lgtm https://codereview.chromium.org/868933003/diff/1/sky/engine/core/dom/Element.cpp File sky/engine/core/dom/Element.cpp (right): https://codereview.chromium.org/868933003/diff/1/sky/engine/core/dom/Element.cpp#newcode1217 sky/engine/core/dom/Element.cpp:1217: // up the keyboard if there's been any ...
5 years, 11 months ago (2015-01-22 23:49:29 UTC) #2
abarth-chromium
https://codereview.chromium.org/868933003/diff/1/sky/engine/core/dom/Element.cpp File sky/engine/core/dom/Element.cpp (right): https://codereview.chromium.org/868933003/diff/1/sky/engine/core/dom/Element.cpp#newcode1217 sky/engine/core/dom/Element.cpp:1217: // up the keyboard if there's been any gesture ...
5 years, 11 months ago (2015-01-22 23:59:13 UTC) #3
abarth-chromium
5 years, 11 months ago (2015-01-23 00:01:35 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0f45ef10f850bcde8e4f2b52945df046bc67da99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698