Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: sky/engine/core/dom/Element.cpp

Issue 868933003: Remove user gesture tracking (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/bindings/core/v8/ScriptController.cpp ('k') | sky/engine/core/frame/DOMTimer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/Element.cpp
diff --git a/sky/engine/core/dom/Element.cpp b/sky/engine/core/dom/Element.cpp
index c82a7d9192882732d05af4943a0aedf5ecd82eff..82b0688455efd527eb1dc8a1235acbc7947729ff 100644
--- a/sky/engine/core/dom/Element.cpp
+++ b/sky/engine/core/dom/Element.cpp
@@ -83,7 +83,6 @@
#include "sky/engine/core/rendering/RenderLayer.h"
#include "sky/engine/core/rendering/RenderView.h"
#include "sky/engine/platform/EventDispatchForbiddenScope.h"
-#include "sky/engine/platform/UserGestureIndicator.h"
#include "sky/engine/platform/scroll/ScrollableArea.h"
#include "sky/engine/wtf/BitVector.h"
#include "sky/engine/wtf/HashFunctions.h"
@@ -1212,13 +1211,11 @@ void Element::focus(bool restorePreviousSelection, FocusType type)
return;
updateFocusAppearance(restorePreviousSelection);
- if (UserGestureIndicator::processedUserGestureSinceLoad()) {
- // Bring up the keyboard in the context of anything triggered by a user
- // gesture. Since tracking that across arbitrary boundaries (eg.
- // animations) is difficult, for now we match IE's heuristic and bring
- // up the keyboard if there's been any gesture since load.
- document().page()->chrome().client().showImeIfNeeded();
- }
+ // Bring up the keyboard in the context of anything triggered by a user
+ // gesture. Since tracking that across arbitrary boundaries (eg.
+ // animations) is difficult, for now we match IE's heuristic and bring
+ // up the keyboard if there's been any gesture since load.
eseidel 2015/01/22 23:49:29 This comment is meaningless, no?
abarth-chromium 2015/01/22 23:59:13 Yes! Thanks.
+ document().page()->chrome().client().showImeIfNeeded();
}
void Element::updateFocusAppearance(bool /*restorePreviousSelection*/)
« no previous file with comments | « sky/engine/bindings/core/v8/ScriptController.cpp ('k') | sky/engine/core/frame/DOMTimer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698