Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: net/quic/quic_sent_packet_manager_test.cc

Issue 868813003: Fix a bug in QUIC's RTO. Flag protected by FLAGS_quic_use_new_rto. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_sent_packet_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager_test.cc
diff --git a/net/quic/quic_sent_packet_manager_test.cc b/net/quic/quic_sent_packet_manager_test.cc
index 6275094d68a6c3f55b5eafea0e9612a237b7bb17..26e5bf5deadeaf73a278726e7df8d81d8b6d9791 100644
--- a/net/quic/quic_sent_packet_manager_test.cc
+++ b/net/quic/quic_sent_packet_manager_test.cc
@@ -1127,19 +1127,21 @@ TEST_F(QuicSentPacketManagerTest, RetransmissionTimeout) {
}
// Ack a retransmission.
- if (FLAGS_quic_use_new_rto) {
- EXPECT_CALL(*send_algorithm_, OnRetransmissionTimeout(true));
- }
QuicAckFrame ack_frame;
ack_frame.delta_time_largest_observed = QuicTime::Delta::Zero();
ack_frame.largest_observed = 102;
for (int i = 0; i < 102; ++i) {
ack_frame.missing_packets.insert(i);
}
+ // Ensure no packets are lost.
EXPECT_CALL(*send_algorithm_,
- OnCongestionEvent(true, _, ElementsAre(Pair(102, _)), _));
+ OnCongestionEvent(true, _, ElementsAre(Pair(102, _)),
+ IsEmpty()) /*lost_packets=*/);
EXPECT_CALL(*network_change_visitor_, OnCongestionWindowChange());
EXPECT_CALL(*network_change_visitor_, OnRttChange());
+ if (FLAGS_quic_use_new_rto) {
+ EXPECT_CALL(*send_algorithm_, OnRetransmissionTimeout(true));
+ }
manager_.OnIncomingAck(ack_frame, clock_.Now());
}
« no previous file with comments | « net/quic/quic_sent_packet_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698