net/quic/quic_sent_packet_manager.cc - Issue 868813003: Fix a bug in QUIC's RTO. Flag protected by FLAGS_quic_use_new_rto.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 868813003: Fix a bug in QUIC's RTO. Flag protected by FLAGS_quic_use_new_rto. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_sent_packet_manager.cc

diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc

index 91775523f835e7d4d8027c020d9a2d8bd83715ba..aaa982c907c9e10cb82866be6e856f6266fe1923 100644

--- a/net/quic/quic_sent_packet_manager.cc

+++ b/net/quic/quic_sent_packet_manager.cc

@@ -215,6 +215,10 @@ void QuicSentPacketManager::OnIncomingAck(const QuicAckFrame& ack_frame,

HandleAckForSentPackets(ack_frame);

InvokeLossDetection(ack_receive_time);

+ // Ignore losses in RTO mode.

+ if (FLAGS_quic_use_new_rto && consecutive_rto_count_ > 0) {

+ packets_lost_.clear();

+ }

MaybeInvokeCongestionEvent(rtt_updated, bytes_in_flight);

unacked_packets_.RemoveObsoletePackets();

« no previous file with comments | « no previous file | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »