Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 868803002: cc: Change the activation/ready for draw check from layer to queue. (Closed)

Created:
5 years, 11 months ago by vmpstr
Modified:
5 years, 10 months ago
Reviewers:
danakj, reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Change the activation/ready for draw check from layer to queue. This patch changes where we do the ready to draw or ready to activate check. Previously, this was done in the layers. Tile manager got all of the picture layers, and asked them if they were ready. How, it just builds a queue of an appropriate type to get this information. R=reveman, danakj Committed: https://crrev.com/831e0aa53be31260b65320176f56a698f2295feb Cr-Commit-Position: refs/heads/master@{#313577}

Patch Set 1 #

Patch Set 2 : +todo #

Patch Set 3 : remove extra patches #

Patch Set 4 : comment format #

Total comments: 6

Patch Set 5 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -142 lines) Patch
M cc/layers/picture_layer_impl.h View 1 2 3 4 2 chunks +0 lines, -8 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 2 3 4 1 chunk +0 lines, -64 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 2 3 4 6 chunks +11 lines, -11 lines 0 comments Download
M cc/resources/tile_manager.h View 1 2 3 4 3 chunks +4 lines, -7 lines 0 comments Download
M cc/resources/tile_manager.cc View 1 2 3 4 1 chunk +19 lines, -19 lines 0 comments Download
M cc/resources/tile_manager_unittest.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/fake_tile_manager_client.h View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
M cc/test/fake_tile_manager_client.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 1 chunk +17 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 4 2 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
vmpstr
Please take a look. This depends on https://codereview.chromium.org/863013004/ https://codereview.chromium.org/862263004/ https://codereview.chromium.org/866883003/
5 years, 11 months ago (2015-01-22 20:04:11 UTC) #1
vmpstr
On 2015/01/22 20:04:11, vmpstr wrote: > Please take a look. This depends on > > ...
5 years, 11 months ago (2015-01-28 00:25:13 UTC) #2
danakj
LGTM https://codereview.chromium.org/868803002/diff/60001/cc/resources/tile_manager.cc File cc/resources/tile_manager.cc (right): https://codereview.chromium.org/868803002/diff/60001/cc/resources/tile_manager.cc#newcode871 cc/resources/tile_manager.cc:871: // check we really want. Hence, we need ...
5 years, 11 months ago (2015-01-28 00:48:19 UTC) #3
vmpstr
https://codereview.chromium.org/868803002/diff/60001/cc/resources/tile_manager.cc File cc/resources/tile_manager.cc (right): https://codereview.chromium.org/868803002/diff/60001/cc/resources/tile_manager.cc#newcode871 cc/resources/tile_manager.cc:871: // check we really want. Hence, we need to ...
5 years, 10 months ago (2015-01-28 19:51:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868803002/80001
5 years, 10 months ago (2015-01-28 19:52:06 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-01-28 20:45:00 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 20:46:11 UTC) #8
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/831e0aa53be31260b65320176f56a698f2295feb
Cr-Commit-Position: refs/heads/master@{#313577}

Powered by Google App Engine
This is Rietveld 408576698