chrome/browser/service_process/service_process_control_browsertest.cc - Issue 868543002: Move OpenProcessHandle to Process::Open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/service_process/service_process_control_browsertest.cc

Issue 868543002: Move OpenProcessHandle to Process::Open. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/process/process_handle_posix.cc ('K') | « chrome/browser/chromeos/policy/device_status_collector.cc ('k') | chrome/test/base/chrome_process_util.cc » ('j') | chrome/test/base/chrome_process_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/service_process/service_process_control_browsertest.cc

diff --git a/chrome/browser/service_process/service_process_control_browsertest.cc b/chrome/browser/service_process/service_process_control_browsertest.cc

index 097b8f597e352c3bd04e393a4f574dbf052a42fb..a159f384f05a446b6c47eb820c7f1b4b66254839 100644

--- a/chrome/browser/service_process/service_process_control_browsertest.cc

+++ b/chrome/browser/service_process/service_process_control_browsertest.cc

@@ -95,12 +95,10 @@ class ServiceProcessControlBrowserTest

service_process_ =

base::Process::OpenWithAccess(service_pid,

SYNCHRONIZE | PROCESS_QUERY_INFORMATION);

- EXPECT_TRUE(service_process_.IsValid());

#else

- base::ProcessHandle service_process_handle;

- EXPECT_TRUE(base::OpenProcessHandle(service_pid, &service_process_handle));

- service_process_ = base::Process(service_process_handle);

+ service_process_ = base::Process::Open(service_pid);

#endif

+ EXPECT_TRUE(service_process_.IsValid());

// Quit the current message. Post a QuitTask instead of just calling Quit()

// because this can get invoked in the context of a Launch() call and we

// may not be in Run() yet.