Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: base/process/process_handle_posix.cc

Issue 868543002: Move OpenProcessHandle to Process::Open. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/process/process_handle_posix.cc
diff --git a/base/process/process_handle_posix.cc b/base/process/process_handle_posix.cc
index 3d92300a7bcadf809559aefdcd46bccb12d0c4fb..a661ecd899b493ee31771c55d854989a20f02e62 100644
--- a/base/process/process_handle_posix.cc
+++ b/base/process/process_handle_posix.cc
@@ -16,13 +16,6 @@ ProcessHandle GetCurrentProcessHandle() {
return GetCurrentProcId();
}
-bool OpenProcessHandle(ProcessId pid, ProcessHandle* handle) {
- // On Posix platforms, process handles are the same as PIDs, so we
- // don't need to do anything.
- *handle = pid;
- return true;
cpu_(ooo_6.6-7.5) 2015/01/28 17:17:50 is zero special? as in returning false?
rvargas (doing something else) 2015/02/02 19:47:09 Zero is the value for invalid handle / pid. This s
-}
-
void CloseProcessHandle(ProcessHandle process) {
// See OpenProcessHandle, nothing to do.
return;

Powered by Google App Engine
This is Rietveld 408576698