Tidy up the allocator shim, which is now Windows only.

Tidy up the allocator shim, which is now Windows only.

Only re-implement the functions that we really need to re-implement to perform our additional checks.  Let the CRT do the rest.  Mark specifically which functions from which CRT files we are re-implementing.  Add missing ones like _query_new_mode.

Fold generic_allocators.cc into allocator_shim_win.cc as this code is now very Windows specific and no point being generic any more.

This is a dependent CL to let ffmpegsumo start using the allocator shims, since it needs _aligned_realloc which the allocator shim never implemented.  Instead, let the CRT do this for us, since it just calls our malloc().

BUG=434397, 450676, 446032, 444533
TEST=base_unittests --gtest_filter=SecurityTest.*
TEST=allocator_unittests

Committed: https://crrev.com/bc1bb9d28de48fe3dd339ed1948bbba9addc4bd9
Cr-Commit-Position: refs/heads/master@{#312720}

[Will Harris, 2015-01-22 04:12:19]

wfh@chromium.org changed reviewers:
+ cpu@chromium.org

[cpu_(ooo_6.6-7.5), 2015-01-22 18:25:15]

https://codereview.chromium.org/868533003/diff/1/base/allocator/allocator_shi...
File base/allocator/allocator_shim_win.cc (right):

https://codereview.chromium.org/868533003/diff/1/base/allocator/allocator_shi...
base/allocator/allocator_shim_win.cc:33: HANDLE win_heap;
kill win_heap

https://codereview.chromium.org/868533003/diff/1/base/allocator/allocator_shi...
base/allocator/allocator_shim_win.cc:222: // Overflow check
period

[DaleCurtis, 2015-01-22 18:28:33]

Do the base/aligned_memory unittests pass after this?

[Will Harris, 2015-01-22 20:00:02]

On 2015/01/22 18:28:33, DaleCurtis wrote:
> Do the base/aligned_memory unittests pass after this?

yes, on my machine all tests pass. See what the trybots say.

cpu@ PTAL

[cpu_(ooo_6.6-7.5), 2015-01-22 21:11:40]

https://codereview.chromium.org/868533003/diff/20001/base/allocator/allocator...
File base/allocator/allocator_shim_win.cc (right):

https://codereview.chromium.org/868533003/diff/20001/base/allocator/allocator...
base/allocator/allocator_shim_win.cc:33: HANDLE win_heap;
: (

[Will Harris, 2015-01-22 21:14:31]

On 2015/01/22 21:11:40, cpu wrote:
> : (

turn that frown upside down and PTAL

[cpu_(ooo_6.6-7.5), 2015-01-22 21:15:30]

lgtm

[Will Harris, 2015-01-22 21:19:59]

The CQ bit was checked by wfh@chromium.org

[commit-bot: I haz the power, 2015-01-22 21:26:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/868533003/40001

[commit-bot: I haz the power, 2015-01-22 23:29:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-22 23:29:01]

Exceeded time limit waiting for builds to trigger.

[Will Harris, 2015-01-22 23:38:35]

The CQ bit was checked by wfh@chromium.org

[commit-bot: I haz the power, 2015-01-22 23:39:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/868533003/40001

[commit-bot: I haz the power, 2015-01-23 01:07:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-23 01:08:09]

Patchset 3 (id:??) landed as
https://crrev.com/bc1bb9d28de48fe3dd339ed1948bbba9addc4bd9
Cr-Commit-Position: refs/heads/master@{#312720}