content/child/service_worker/service_worker_registration_handle_reference.cc - Issue 868483008: ServiceWorker: Fix registration refcount handling in the renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/service_worker_registration_handle_reference.cc

Issue 868483008: ServiceWorker: Fix registration refcount handling in the renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/child/service_worker/service_worker_registration_handle_reference.cc

diff --git a/content/child/service_worker/service_worker_registration_handle_reference.cc b/content/child/service_worker/service_worker_registration_handle_reference.cc

index 438bce486c0de95ad2dfed8a82592a69c63d0af6..7a9e2847ae0ca23c25f5e983f864201a2d4ee978 100644

--- a/content/child/service_worker/service_worker_registration_handle_reference.cc

+++ b/content/child/service_worker/service_worker_registration_handle_reference.cc

@@ -34,7 +34,7 @@ ServiceWorkerRegistrationHandleReference(

sender_(sender) {

DCHECK_NE(kInvalidServiceWorkerRegistrationHandleId, info_.handle_id);

DCHECK(sender_.get());

- if (increment_ref_in_ctor)

+ if (!increment_ref_in_ctor)

return;

sender_->Send(

new ServiceWorkerHostMsg_IncrementRegistrationRefCount(info_.handle_id));

« no previous file with comments | « content/child/service_worker/service_worker_message_filter.cc ('k') | no next file » | no next file with comments »