Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Unified Diff: content/child/service_worker/service_worker_message_filter.cc

Issue 868483008: ServiceWorker: Fix registration refcount handling in the renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/child/service_worker/service_worker_registration_handle_reference.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/service_worker/service_worker_message_filter.cc
diff --git a/content/child/service_worker/service_worker_message_filter.cc b/content/child/service_worker/service_worker_message_filter.cc
index 9b3cd56918423596ee321337f14294bf640f53f2..b0554c003d7e5ba68c7268d50585f736f342dca1 100644
--- a/content/child/service_worker/service_worker_message_filter.cc
+++ b/content/child/service_worker/service_worker_message_filter.cc
@@ -104,8 +104,8 @@ void ServiceWorkerMessageFilter::OnStaleSetVersionAttributes(
attrs.waiting.handle_id);
SendServiceWorkerObjectDestroyed(thread_safe_sender_.get(),
attrs.active.handle_id);
- SendRegistrationObjectDestroyed(thread_safe_sender_.get(),
- registration_handle_id);
+ // Don't have to decrement registration refcount because the sender of the
+ // SetVersionAttributes message doesn't increment it.
}
void ServiceWorkerMessageFilter::OnStaleSetControllerServiceWorker(
« no previous file with comments | « no previous file | content/child/service_worker/service_worker_registration_handle_reference.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698