Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: sky/framework/inspector/inspector.sky

Issue 868463008: Remove Client relationship between mojo.Shell/mojo.Application (Closed) Base URL: git@github.com:domokit/mojo.git@app_impl_init
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/framework/inspector/inspector.sky
diff --git a/sky/framework/inspector/inspector.sky b/sky/framework/inspector/inspector.sky
index aa2fe070da95a036204269e59016157020663baf..32ff5b135965737b4c17445e602be8509578d95c 100644
--- a/sky/framework/inspector/inspector.sky
+++ b/sky/framework/inspector/inspector.sky
@@ -1,7 +1,8 @@
<import src="/mojo/public/sky/connection.sky" as="connection" />
<import src="/mojo/public/sky/core.sky" as="core" />
<import src="/mojo/public/sky/support.sky" as="support" />
-<import src="/mojo/services/public/sky/application.sky" as="application" />
+<import src="/mojo/public/interfaces/application/shell.mojom.sky" as="shellMojom" />
+<import src="/mojo/services/public/sky/shell.sky" as="shell" />
<import src="/sky/services/inspector/inspector.mojom.sky" as="inspector" />
<import src="console-agent.sky" as="ConsoleAgent" />
<import src="dom-agent.sky" as="DOMAgent" />
@@ -117,8 +118,10 @@ class InspectorBackend extends inspector.InspectorBackend.stubClass {
}
(function() {
- var app = new application.Application(internals.passShellProxyHandle());
- var tracingApp = app.shell.connectToApplication("mojo:sky_inspector_server");
+ var shellHandle = internals.passShellProxyHandle();
+ var shellProxy = connection.bindHandleToProxy(shellHandle, shellMojom.Shell);
+ var myShell = new shell.Shell(shellProxy)
+ var tracingApp = myShell.connectToApplication("mojo:sky_inspector_server");
tracingApp.provideService(inspector.InspectorBackend, InspectorBackend);
window.frontend = tracingApp.requestService(inspector.InspectorFrontend);

Powered by Google App Engine
This is Rietveld 408576698