Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: shell/out_of_process_dynamic_service_runner.cc

Issue 868463008: Remove Client relationship between mojo.Shell/mojo.Application (Closed) Base URL: git@github.com:domokit/mojo.git@app_impl_init
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: shell/out_of_process_dynamic_service_runner.cc
diff --git a/shell/out_of_process_dynamic_service_runner.cc b/shell/out_of_process_dynamic_service_runner.cc
index 45d57ef0db8e176da0aeec67828e1f8853f8e2a6..f6d4a1b369494e5010b3e2e9267d5356cdfb8578 100644
--- a/shell/out_of_process_dynamic_service_runner.cc
+++ b/shell/out_of_process_dynamic_service_runner.cc
@@ -30,7 +30,7 @@ OutOfProcessDynamicServiceRunner::~OutOfProcessDynamicServiceRunner() {
void OutOfProcessDynamicServiceRunner::Start(
const base::FilePath& app_path,
- ScopedMessagePipeHandle service_handle,
+ InterfaceRequest<Application> application_request,
const base::Closure& app_completed_callback) {
app_path_ = app_path;
@@ -41,9 +41,8 @@ void OutOfProcessDynamicServiceRunner::Start(
app_child_process_host_->Start();
// TODO(vtl): |app_path.AsUTF8Unsafe()| is unsafe.
- app_child_process_host_->controller()->StartApp(
- app_path.AsUTF8Unsafe(), ScopedMessagePipeHandle(MessagePipeHandle(
- service_handle.release().value())));
+ app_child_process_host_->controller()->StartApp(app_path.AsUTF8Unsafe(),
+ application_request.Pass());
}
void OutOfProcessDynamicServiceRunner::AppCompleted(int32_t result) {

Powered by Google App Engine
This is Rietveld 408576698