Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: mojo/services/public/js/shell.js

Issue 868463008: Remove Client relationship between mojo.Shell/mojo.Application (Closed) Base URL: git@github.com:domokit/mojo.git@app_impl_init
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/public/js/shell.js
diff --git a/mojo/services/public/js/shell.js b/mojo/services/public/js/shell.js
index 40677d913e6f7bd3567cf67413905980147459e2..d80a2e9ad57e734ec5fe41dfc03d339f3fbd7e0e 100644
--- a/mojo/services/public/js/shell.js
+++ b/mojo/services/public/js/shell.js
@@ -18,12 +18,8 @@ define("mojo/services/public/js/shell", [
const ShellInterface = shellMojom.Shell;
class Shell {
- constructor(shellHandle, app) {
- this.shellHandle = shellHandle;
- this.shellProxy = connection.bindProxyHandle(
- shellHandle, ShellInterface.client, ShellInterface);
-
- ProxyBindings(this.shellProxy).setLocalDelegate(app);
+ constructor(shellProxy) {
+ this.shellProxy = shellProxy;
this.applications_ = new Map();
}
@@ -50,8 +46,9 @@ define("mojo/services/public/js/shell", [
this.applications_.forEach(function(application, url) {
application.close();
});
+ // TODO(hansmuller): Use a proper API on Proxy to close.
+ core.close(this.shellProxy.handleStash);
this.applications_.clear();
- core.close(this.shellHandle);
}
}

Powered by Google App Engine
This is Rietveld 408576698