Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: mojo/services/public/js/application.js

Issue 868463008: Remove Client relationship between mojo.Shell/mojo.Application (Closed) Base URL: git@github.com:domokit/mojo.git@app_impl_init
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/public/js/application.js
diff --git a/mojo/services/public/js/application.js b/mojo/services/public/js/application.js
index a75c848da00509e5ffbb386708f47b8573343253..d4aa1e674236691fa1643ee8966f42f5fb6ebe2b 100644
--- a/mojo/services/public/js/application.js
+++ b/mojo/services/public/js/application.js
@@ -3,29 +3,42 @@
// found in the LICENSE file.
define("mojo/services/public/js/application", [
+ "mojo/public/js/bindings",
+ "mojo/public/js/core",
+ "mojo/public/js/connection",
"mojo/public/js/threading",
+ "mojo/public/interfaces/application/application.mojom",
"mojo/services/public/js/service_provider",
"mojo/services/public/js/shell",
-], function(threading, serviceProvider, shell) {
+], function(bindings, core, connection, threading, applicationMojom, serviceProvider, shell) {
+ const ApplicationInterface = applicationMojom.Application;
+ const ProxyBindings = bindings.ProxyBindings;
const ServiceProvider = serviceProvider.ServiceProvider;
const Shell = shell.Shell;
class Application {
- constructor(shellHandle, url) {
+ constructor(appRequestHandle, url) {
this.url = url;
this.serviceProviders = [];
this.exposedServiceProviders = [];
- this.shellHandle_ = shellHandle;
- this.shell = new Shell(shellHandle, {
- initialize: this.initialize.bind(this),
- acceptConnection: this.doAcceptConnection.bind(this),
- });
+ this.appRequestHandle_ = appRequestHandle;
+ this.appStub_ =
+ connection.bindHandleToStub(appRequestHandle, ApplicationInterface);
+ bindings.StubBindings(this.appStub_).delegate = {
+ initialize: this.doInitialize.bind(this),
+ acceptConnection: this.doAcceptConnection.bind(this),
+ };
}
- initialize(args) {
+ doInitialize(shellProxy, args) {
+ this.shellProxy_ = shellProxy;
+ this.shell = new Shell(shellProxy);
+ this.initialize(args);
}
+ initialize(args) {}
+
// The mojom signature of this function is:
// AcceptConnection(string requestor_url,
// ServiceProvider&? services,
@@ -43,14 +56,14 @@ define("mojo/services/public/js/application", [
this.acceptConnection(requestorUrl, serviceProvider);
}
- acceptConnection(requestorUrl, serviceProvider) {
- }
+ acceptConnection(requestorUrl, serviceProvider) {}
quit() {
this.serviceProviders.forEach(function(sp) {
sp.close();
});
this.shell.close();
+ core.close(this.appRequestHandle_);
threading.quit();
}
}

Powered by Google App Engine
This is Rietveld 408576698