Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 868453005: Continue learning for calls in optimized code when we have no type feedback. (Closed)

Created:
5 years, 11 months ago by mvstanton
Modified:
5 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@navier
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Continue learning for calls in optimized code when we have no type feedback. Based on CL https://codereview.chromium.org/871063002/ which needs to land first. BUG= Committed: https://crrev.com/f5f2692b5ff70ac3cd06a903b7846174b97a2e55 Cr-Commit-Position: refs/heads/master@{#26292}

Patch Set 1 #

Patch Set 2 : Ports. #

Patch Set 3 : REBASE. #

Patch Set 4 : Compile error fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -33 lines) Patch
M src/arm/lithium-arm.h View 1 1 chunk +8 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 2 chunks +23 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 3 1 chunk +23 lines, -2 lines 0 comments Download
M src/arm64/lithium-arm64.h View 1 1 chunk +8 lines, -2 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 2 chunks +23 lines, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 2 1 chunk +23 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +13 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +21 lines, -7 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 1 chunk +23 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 1 chunk +8 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +23 lines, -1 line 0 comments Download
M src/ic/ic.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 1 2 3 chunks +30 lines, -5 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 1 chunk +23 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.h View 1 2 chunks +9 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
lgtm
5 years, 10 months ago (2015-01-27 10:32:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868453005/60001
5 years, 10 months ago (2015-01-27 12:12:21 UTC) #4
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-01-27 12:33:05 UTC) #5
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/f5f2692b5ff70ac3cd06a903b7846174b97a2e55 Cr-Commit-Position: refs/heads/master@{#26292}
5 years, 10 months ago (2015-01-27 12:33:16 UTC) #6
mvstanton
5 years, 10 months ago (2015-01-27 13:06:23 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/878103002/ by mvstanton@chromium.org.

The reason for reverting is: Serializer tests broke. Need to debug and fix..

Powered by Google App Engine
This is Rietveld 408576698