Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: src/hydrogen.cc

Issue 868453005: Continue learning for calls in optimized code when we have no type feedback. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@navier
Patch Set: Compile error fix. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/hydrogen.h" 5 #include "src/hydrogen.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/v8.h" 9 #include "src/v8.h"
10 10
(...skipping 9330 matching lines...) Expand 10 before | Expand all | Expand 10 after
9341 9341
9342 if (TryInlineCall(expr)) return; 9342 if (TryInlineCall(expr)) return;
9343 9343
9344 call = PreProcessCall(New<HInvokeFunction>( 9344 call = PreProcessCall(New<HInvokeFunction>(
9345 function, expr->target(), argument_count)); 9345 function, expr->target(), argument_count));
9346 9346
9347 } else { 9347 } else {
9348 Push(graph()->GetConstantUndefined()); 9348 Push(graph()->GetConstantUndefined());
9349 CHECK_ALIVE(VisitExpressions(expr->arguments())); 9349 CHECK_ALIVE(VisitExpressions(expr->arguments()));
9350 PushArgumentsFromEnvironment(argument_count); 9350 PushArgumentsFromEnvironment(argument_count);
9351 call = New<HCallFunction>(function, argument_count); 9351 HCallFunction* call_function =
9352 New<HCallFunction>(function, argument_count);
9353 call = call_function;
9354 if (expr->is_uninitialized() && expr->HasCallFeedbackSlot()) {
9355 // We've never seen this call before, so let's have Crankshaft learn
9356 // through the type vector.
9357 Handle<SharedFunctionInfo> current_shared =
9358 function_state()->compilation_info()->shared_info();
9359 Handle<TypeFeedbackVector> vector =
9360 handle(current_shared->feedback_vector(), isolate());
9361 FeedbackVectorICSlot slot = expr->CallFeedbackSlot();
9362 call_function->SetVectorAndSlot(vector, slot);
9363 }
9352 } 9364 }
9353 } 9365 }
9354 9366
9355 Drop(1); // Drop the function. 9367 Drop(1); // Drop the function.
9356 return ast_context()->ReturnInstruction(call, expr->id()); 9368 return ast_context()->ReturnInstruction(call, expr->id());
9357 } 9369 }
9358 9370
9359 9371
9360 void HOptimizedGraphBuilder::BuildInlinedCallArray( 9372 void HOptimizedGraphBuilder::BuildInlinedCallArray(
9361 Expression* expression, 9373 Expression* expression,
(...skipping 4108 matching lines...) Expand 10 before | Expand all | Expand 10 after
13470 if (ShouldProduceTraceOutput()) { 13482 if (ShouldProduceTraceOutput()) {
13471 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 13483 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
13472 } 13484 }
13473 13485
13474 #ifdef DEBUG 13486 #ifdef DEBUG
13475 graph_->Verify(false); // No full verify. 13487 graph_->Verify(false); // No full verify.
13476 #endif 13488 #endif
13477 } 13489 }
13478 13490
13479 } } // namespace v8::internal 13491 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698