Rename is_visible to is_reflectable; use is_debuggable instead of is_reflectable

runtime/vm/debugger.cc

Index: runtime/vm/debugger.cc
diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc
index b23640b88bf3c98ccce5628ccb13de74d085bf50..c7a45745ffe2c3565153c296704df7408f7c236d 100644
--- a/runtime/vm/debugger.cc
+++ b/runtime/vm/debugger.cc
@@ -905,7 +905,7 @@ void ActivationFrame::PrintToJSONObject(JSONObject* jsobj) {
 
 
 void DebuggerStackTrace::AddActivation(ActivationFrame* frame) {
-  if (FLAG_show_invisible_frames || frame->function().is_visible()) {
+  if (FLAG_show_invisible_frames || frame->function().is_stacktrace_visible()) {

[Ivan Posva, 2015/01/23 19:37:07]

Shouldn't we just use is_debuggable() here instead of adding the alias
is_stacktrace_visible?

[rmacnak, 2015/01/23 21:16:17]

Yeah, flattened these out.

     trace_.Add(frame);
   }
 }
@@ -1323,7 +1323,7 @@ DebuggerStackTrace* Debugger::StackTraceFrom(const Stacktrace& ex_trace) {
     // pre-allocated trace (such as a stack overflow) or (b) because a stack has
     // fewer frames that the pre-allocated trace (such as memory exhaustion with
     // a shallow stack).
-    if (!function.IsNull() && function.is_visible()) {
+    if (!function.IsNull() && function.is_stacktrace_visible()) {
       code = ex_trace.CodeAtFrame(i);
       ASSERT(function.raw() == code.function());
       uword pc = code.EntryPoint() + Smi::Value(ex_trace.PcOffsetAtFrame(i));