Issue 868233005: Revert of Move npot resizing out of GrContext and simplify GrContext texture functions.

Issue 868233005: Revert of Move npot resizing out of GrContext and simplify GrContext texture functions. (Closed)

Created:
5 years, 10 months ago by f(malita)

Modified:
5 years, 10 months ago

Reviewers:
bsalomon, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Move npot resizing out of GrContext and simplify GrContext texture functions. (patchset #9 id:160001 of https://codereview.chromium.org/882223003/) Reason for revert: webGL conformance failures: WebglConformance.conformance_textures_tex_image_and_sub_image_2d_with_video WebglConformance.conformance_textures_texture_npot_video https://codereview.chromium.org/892773003/ http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/29272 Original issue's description: > Move npot resizing out of GrContext and simplify GrContext texture functions. > > Committed: https://skia.googlesource.com/skia/+/8a8100349105c8c6de39fcb34e47679da7a67f54 TBR=robertphillips@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/6bfef2dfec3253efa48aec0b5ea108e0dc041d15

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+435 lines, -346 lines)			Patch
M	include/gpu/GrContext.h	View	4 chunks	+68 lines, -41 lines	0 comments	Download
M	include/gpu/GrPaint.h	View	1 chunk	+11 lines, -3 lines	0 comments	Download
M	include/gpu/GrResourceKey.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/gpu/GrTypes.h	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	src/effects/SkBlurMaskFilter.cpp	View	4 chunks	+18 lines, -20 lines	0 comments	Download
M	src/effects/SkColorCubeFilter.cpp	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	4 chunks	+243 lines, -32 lines	0 comments	Download
M	src/gpu/SkGr.cpp	View	14 chunks	+79 lines, -217 lines	0 comments	Download
M	src/gpu/effects/GrTextureStripAtlas.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/GLProgramsTest.cpp	View	1 chunk	+7 lines, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

f(malita)

Created Revert of Move npot resizing out of GrContext and simplify GrContext texture functions.

5 years, 10 months ago (2015-01-31 15:01:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868233005/1

5 years, 10 months ago (2015-01-31 15:02:08 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-01-31 15:02:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6bfef2dfec3253efa48aec0b5ea108e0dc041d15