[chromedriver] Make testConsoleLogSources handle missing favicon error

[chromedriver] Make testConsoleLogSources handle missing favicon error

BUG=
NOTRY=true

Committed: https://crrev.com/b179c5de0dc3689ddf1942aabd28926d9d14c4c4
Cr-Commit-Position: refs/heads/master@{#312923}

[samuong, 2015-01-23 18:27:34]

This started to be flaky on Mac for ToT Chrome builds because the browser
sometimes requests a favicon and gets a 404.

[samuong, 2015-01-23 18:27:52]

samuong@chromium.org changed reviewers:
+ stgao@chromium.org

[samuong, 2015-01-23 18:27:53]

+stgao@

[stgao, 2015-01-23 19:45:55]

lgtm

https://codereview.chromium.org/868153002/diff/1/chrome/test/chromedriver/tes...
File chrome/test/chromedriver/test/run_py_tests.py (right):

https://codereview.chromium.org/868153002/diff/1/chrome/test/chromedriver/tes...
chrome/test/chromedriver/test/run_py_tests.py:737: # Sometimes, we also get an
error for a missing favicon.
Just FYI: another idea is to add a dummy favicon to the test data directory that
the HTTP server is serving.

[samuong, 2015-01-23 20:25:30]

On 2015/01/23 19:45:55, Shuotao wrote:
> lgtm
> 
>
https://codereview.chromium.org/868153002/diff/1/chrome/test/chromedriver/tes...
> File chrome/test/chromedriver/test/run_py_tests.py (right):
> 
>
https://codereview.chromium.org/868153002/diff/1/chrome/test/chromedriver/tes...
> chrome/test/chromedriver/test/run_py_tests.py:737: # Sometimes, we also get an
> error for a missing favicon.
> Just FYI: another idea is to add a dummy favicon to the test data directory
that
> the HTTP server is serving.

That makes sense, but I'll leave it like this so that the test stays
self-contained and doesn't rely on too many files outside of the chromedriver
directory. Let me know if you prefer otherwise.

[stgao, 2015-01-23 20:41:45]

On 2015/01/23 20:25:30, samuong wrote:
> On 2015/01/23 19:45:55, Shuotao wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/868153002/diff/1/chrome/test/chromedriver/tes...
> > File chrome/test/chromedriver/test/run_py_tests.py (right):
> > 
> >
>
https://codereview.chromium.org/868153002/diff/1/chrome/test/chromedriver/tes...
> > chrome/test/chromedriver/test/run_py_tests.py:737: # Sometimes, we also get
an
> > error for a missing favicon.
> > Just FYI: another idea is to add a dummy favicon to the test data directory
> that
> > the HTTP server is serving.
> 
> That makes sense, but I'll leave it like this so that the test stays
> self-contained and doesn't rely on too many files outside of the chromedriver
> directory. Let me know if you prefer otherwise.

The fix lgtm, you could commit it.

[samuong, 2015-01-23 20:53:29]

The CQ bit was checked by samuong@chromium.org

[commit-bot: I haz the power, 2015-01-23 20:54:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/868153002/1

[commit-bot: I haz the power, 2015-01-23 20:55:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-23 20:57:40]

Patchset 1 (id:??) landed as
https://crrev.com/b179c5de0dc3689ddf1942aabd28926d9d14c4c4
Cr-Commit-Position: refs/heads/master@{#312923}