[chromedriver] Make testConsoleLogSources handle missing favicon error

chrome/test/chromedriver/test/run_py_tests.py

 #!/usr/bin/env python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """End to end tests for ChromeDriver."""
 
 import base64
 import json
 import math
@@ skipping 708 matching lines @@
     # Set size first so that the window isn't moved offscreen.
     # See https://code.google.com/p/chromedriver/issues/detail?id=297.
     self._driver.SetWindowSize(600, 400)
     self._driver.SetWindowPosition(100, 200)
     self.assertEquals([100, 200], self._driver.GetWindowPosition())
     self.assertEquals([600, 400], self._driver.GetWindowSize())
 
   def testConsoleLogSources(self):
     self._driver.Load(self.GetHttpUrlForFile('/chromedriver/console_log.html'))
     logs = self._driver.GetLog('browser')
-    self.assertEquals(len(logs), 2)
-    self.assertEquals(logs[0]['source'], 'network')
-    self.assertEquals(logs[1]['source'], 'javascript')
+
+    self.assertEqual('network', logs[0]['source'])
+    self.assertTrue('nonexistent.png' in logs[0]['message'])
+    self.assertTrue('404' in logs[0]['message'])
+
+    self.assertEqual('javascript', logs[1]['source'])
+    self.assertTrue('TypeError' in logs[1]['message'])
+
+    # Sometimes, we also get an error for a missing favicon.

[stgao, 2015/01/23 19:45:55]

Just FYI: another idea is to add a dummy favicon to the test data directory that
the HTTP server is serving.

+    if len(logs) > 2:
+      self.assertEqual('network', logs[2]['source'])
+      self.assertTrue('favicon.ico' in logs[2]['message'])
+      self.assertTrue('404' in logs[2]['message'])
+      self.assertEqual(3, len(logs))
+    else:
+      self.assertEqual(2, len(logs))
 
   def testAutoReporting(self):
     self.assertFalse(self._driver.IsAutoReporting())
     self._driver.SetAutoReporting(True)
     self.assertTrue(self._driver.IsAutoReporting())
     url = self.GetHttpUrlForFile('/chromedriver/console_log.html')
     self.assertRaisesRegexp(chromedriver.UnknownError,
                             '.*(404|Failed to load resource).*',
                             self._driver.Load,
                             url)
@@ skipping 690 matching lines @@
 
   all_tests_suite = unittest.defaultTestLoader.loadTestsFromModule(
       sys.modules[__name__])
   tests = unittest_util.FilterTestSuite(all_tests_suite, options.filter)
   ChromeDriverTest.GlobalSetUp()
   MobileEmulationCapabilityTest.GlobalSetUp()
   result = unittest.TextTestRunner(stream=sys.stdout, verbosity=2).run(tests)
   ChromeDriverTest.GlobalTearDown()
   MobileEmulationCapabilityTest.GlobalTearDown()
   sys.exit(len(result.failures) + len(result.errors))