Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 868133005: [Smart Lock] Add error message strings for the "Tx Power too high" case. (Closed)

Created:
5 years, 11 months ago by Ilya Sherman
Modified:
5 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, asvitkine+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Add error message strings for the "Tx Power too high" case. BUG=450498 TEST=none R=tengs@chromium.org TBR=nkostylev@chromium.org Committed: https://crrev.com/4f4fd12fc21c1ec0956f9a2b64689e8e6a764ed2 Cr-Commit-Position: refs/heads/master@{#313777}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Update TODO comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -5 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_metrics.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler.cc View 1 3 chunks +12 lines, -2 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/easy_unlock_private.idl View 1 chunk +6 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
Ilya Sherman
5 years, 11 months ago (2015-01-24 02:15:19 UTC) #1
Tim Song
https://codereview.chromium.org/868133005/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/868133005/diff/1/chrome/app/generated_resources.grd#newcode15286 chrome/app/generated_resources.grd:15286: + Can’t find your phone. Make sure it’s within ...
5 years, 11 months ago (2015-01-24 02:38:32 UTC) #2
Ilya Sherman
https://codereview.chromium.org/868133005/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/868133005/diff/1/chrome/app/generated_resources.grd#newcode15286 chrome/app/generated_resources.grd:15286: + Can’t find your phone. Make sure it’s within ...
5 years, 11 months ago (2015-01-27 01:20:24 UTC) #3
Tim Song
lgtm https://codereview.chromium.org/868133005/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/868133005/diff/1/chrome/app/generated_resources.grd#newcode15286 chrome/app/generated_resources.grd:15286: + Can’t find your phone. Make sure it’s ...
5 years, 11 months ago (2015-01-27 19:00:00 UTC) #4
Ilya Sherman
+nkostylev for //chrome/browser/chromeos/login +yoz for //chrome/common/extensions
5 years, 11 months ago (2015-01-27 21:03:19 UTC) #6
Yoyo Zhou
idl LGTM
5 years, 11 months ago (2015-01-27 23:46:19 UTC) #7
Ilya Sherman
TBRing nkostylev
5 years, 10 months ago (2015-01-29 00:44:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868133005/20001
5 years, 10 months ago (2015-01-29 00:45:19 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/28297)
5 years, 10 months ago (2015-01-29 02:07:21 UTC) #12
Nikita (slow)
On 2015/01/27 21:03:19, Ilya Sherman wrote: > +nkostylev for //chrome/browser/chromeos/login > +yoz for //chrome/common/extensions lgtm
5 years, 10 months ago (2015-01-29 10:34:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868133005/20001
5 years, 10 months ago (2015-01-29 20:06:39 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-29 20:37:08 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 20:38:08 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4f4fd12fc21c1ec0956f9a2b64689e8e6a764ed2
Cr-Commit-Position: refs/heads/master@{#313777}

Powered by Google App Engine
This is Rietveld 408576698