Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 868133003: Remove touch events from Sky (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
esprehn
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1679 lines) Patch
M sky/engine/core/core.gni View 5 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/core/dom/Document.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 2 chunks +0 lines, -35 lines 0 comments Download
M sky/engine/core/dom/Document.idl View 1 chunk +0 lines, -13 lines 0 comments Download
M sky/engine/core/dom/Node.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Node.cpp View 4 chunks +0 lines, -13 lines 0 comments Download
D sky/engine/core/dom/Touch.h View 1 chunk +0 lines, -102 lines 0 comments Download
D sky/engine/core/dom/Touch.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
D sky/engine/core/dom/Touch.idl View 1 chunk +0 lines, -40 lines 0 comments Download
D sky/engine/core/dom/TouchList.h View 1 chunk +0 lines, -72 lines 0 comments Download
D sky/engine/core/dom/TouchList.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
D sky/engine/core/dom/TouchList.idl View 1 chunk +0 lines, -31 lines 0 comments Download
M sky/engine/core/events/Event.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/events/Event.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/events/EventAliases.in View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/events/EventPath.h View 4 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/core/events/EventPath.cpp View 2 chunks +1 line, -56 lines 0 comments Download
M sky/engine/core/events/EventTypeNames.in View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/events/NodeEventContext.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/events/NodeEventContext.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M sky/engine/core/events/ThreadLocalEventNames.h View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/engine/core/events/TouchEvent.h View 1 chunk +0 lines, -100 lines 0 comments Download
D sky/engine/core/events/TouchEvent.cpp View 1 chunk +0 lines, -126 lines 0 comments Download
D sky/engine/core/events/TouchEvent.idl View 1 chunk +0 lines, -47 lines 0 comments Download
D sky/engine/core/events/TouchEventContext.h View 1 chunk +0 lines, -59 lines 0 comments Download
D sky/engine/core/events/TouchEventContext.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
M sky/engine/core/events/TreeScopeEventContext.h View 3 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/events/TreeScopeEventContext.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M sky/engine/core/frame/NewEventHandler.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/Settings.in View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/page/EventHandler.h View 3 chunks +0 lines, -13 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 9 chunks +10 lines, -262 lines 0 comments Download
M sky/engine/core/rendering/HitTestRequest.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/platform/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/platform/PlatformEvent.h View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/engine/platform/PlatformTouchEvent.h View 1 chunk +0 lines, -48 lines 0 comments Download
D sky/engine/platform/PlatformTouchPoint.h View 1 chunk +0 lines, -66 lines 0 comments Download
M sky/engine/platform/exported/WebInputEvent.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/public/platform/WebInputEvent.h View 4 chunks +0 lines, -52 lines 0 comments Download
D sky/engine/public/platform/WebTouchPoint.h View 1 chunk +0 lines, -73 lines 0 comments Download
M sky/engine/public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebInputEventConversion.h View 4 chunks +0 lines, -23 lines 0 comments Download
M sky/engine/web/WebInputEventConversion.cpp View 3 chunks +0 lines, -136 lines 0 comments Download
M sky/engine/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 4 chunks +0 lines, -22 lines 0 comments Download
M sky/examples/touch-demo.sky View 1 chunk +10 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 11 months ago (2015-01-23 20:40:06 UTC) #1
esprehn
lgtm
5 years, 11 months ago (2015-01-23 20:40:55 UTC) #2
abarth-chromium
5 years, 11 months ago (2015-01-23 20:42:01 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e17ac3c7c2ee1e087ffbb2f45ed7bce39591f7a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698